Project

General

Profile

Feature #692371

Send server setting defaultness to client

Added by Jacob Nevins almost 3 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In 2.6, the server introduced a notion of whether a setting was tracking the server/ruleset default or had an explicitly set value (enum setting_default_level).

The client's server settings storage also has such a notion, but it simply compares the current value to the server's current default at the time the client's server settings are saved (desired_settable_options_update()). This has the risk that if settings are saved when playing a ruleset which happens to have the same default as the user's desired default, the user's preference is lost for other rulesets.

It would be better if the client tracked an explicit notion of defaultness, and the 'Reset' buttons in clients' UI sent '/default' commands, etc.

I think the first step needed for this (before d3f) is to expose (struct setting).setdef over the network.


Related issues

Blocks Freeciv - Task #656467: S3_0 network protocol freeze (npf)Closed2020-03-072020-03-07

History

#1 Updated by Jacob Nevins almost 3 years ago

  • Blocks Task #656467: S3_0 network protocol freeze (npf) added

#3 Updated by Marko Lindqvist 6 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF