Project

General

Profile

Feature #747319

Refactor network stream uncompressing

Added by Marko Lindqvist over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Split from Bug #746878.

Instead of assuming that certain size buffer is big enough for uncompressed data and having an hard error if it doesn't, uncompressing should be retried with bigger buffer if needed.

History

#1 Updated by Sim Sulla over 1 year ago

I have corrected #747319. Now we retry with a bigger buffer. There is still a max decompression to prevent a zip bomb.

See https://github.com/freeciv/freeciv/pull/10

#2 Updated by Marko Lindqvist over 1 year ago

Please read doc/CodingStyle. Use spaces instead of tabs and correct the indentation in general.

The commit messages should list also who reported the issue, and who made the patch if different from the commit author. See existing git logs for examples of commit messages.

#3 Updated by Sim Sulla over 1 year ago

I have corrected the indentation (sorry about the tabs). The correction commit follows what seems to be custom in other commits (i.e. referencing the hrm in the end of the message). The hrm provides info on who reported the issue, and the git commit about who did the correction. All is in the pull request.

#4 Updated by Marko Lindqvist over 1 year ago

Sim Sulla wrote:

The hrm provides info on who reported the issue

The main reason we've been adding them directly to commit messages is to make it easier for Release Manager to collect them for credits in PEOPLE. There's thousands of commits between major versions, so clicking and reading through all the tickets for figuring out the reporters would make already big task enormous. Also, as demonstrated by the loss of ticket trackers in the past, information in the tickets is not as permanent as in commit messages.
Reporter or patch author doesn't need to be specified if it's the person making the commit (= the default is that committer has done both of those actions)

#5 Updated by Marko Lindqvist over 1 year ago

A bit updated versions attached.

- Also S2_6 version of the patch
- Corrected indentation
- Removed outdated comment
- Made initial buffer size smaller (100 > 80) than traditionally now that it's not necessary to be big enough for all cases
Made increase smaller (100 -> 50)

#6 Updated by Marko Lindqvist over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF