Project

General

Profile

Bug #767129

Nation-specific starting units can start on non-native terrain, or on hut tile

Added by Jacob Nevins over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Category:
Server
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

While looking at init_new_game() for bug #767127, I noticed that standard player start units are placed with place_starting_unit(), which finds the nearest tile the unit type can exist on and gets rid of any hut there; but nation-specific start units don't benefit from this. Probably there's no good reason for the difference?


Related issues

Related to Freeciv - Bug #767127: Server can hang in find_dispersed_position() if scenario has invalid start positionNew

History

#1 Updated by Jacob Nevins over 1 year ago

  • Related to Bug #767127: Server can hang in find_dispersed_position() if scenario has invalid start position added

#2 Updated by Marko Lindqvist 5 months ago

Fix attached

Jacob Nevins wrote:

Probably there's no good reason for the difference?

Probably it was that way since create_starting_unit() took unit role while nation specific start units are already a specific unit type. Changed create_starting_unit() to work with either.

#3 Updated by Marko Lindqvist 5 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF