Project

General

Profile

Feature #655676

Split "Investigate City" in consuming/non consuming versions

Added by Sveinung Kvilhaugsvik 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
Due date:
% Done:

100%


Description

This replaces relying on the Spy unit type flag to decide if the unit is consumed.

David Fernandez requested the ability to allow civ2civ3 diplomats and explorers to survive city investigation in Feature #650794. (Making those changes to civ2civ3 and sandbox are not handled in this patch. If this patch introduces any rule change it is a bug.)

3.0-Split-Investigate-City.patch View (45.9 KB) Sveinung Kvilhaugsvik, 2017-04-27 03:51 PM

3.1-Split-Investigate-City.patch View (43.7 KB) Sveinung Kvilhaugsvik, 2017-04-27 03:51 PM

3.1-Split-Investigate-City-v2.patch View (44.3 KB) Sveinung Kvilhaugsvik, 2017-04-28 12:08 PM

3.0-Split-Investigate-City-v2.patch View (46.5 KB) Sveinung Kvilhaugsvik, 2017-04-28 12:08 PM

History

#1 Updated by Sveinung Kvilhaugsvik 5 months ago

#2 Updated by Sveinung Kvilhaugsvik 5 months ago

v2:
- comment text improvements

#3 Updated by Sveinung Kvilhaugsvik 5 months ago

  • Status changed from Resolved to Closed
  • % Done changed from 90 to 100

#4 Updated by David Fernandez (bard) 5 months ago

Thank you very much, I'll test them.
And I'll make the patches to introduce them to civ2civ3 as soon as I start working on v3.0 (I'm still testing my latest changes to v2.6).

#5 Updated by David Fernandez (bard) 2 months ago

I made the patch here: Feature #683542.

Sveinung, may these non-consuming actions (with 100% success chance) increase the veterancy of the agent?
In my tests, it seems the answer is no for "Investigate City", but I wanted to point it in case other similar actions may be exploited this way.

#6 Updated by Sveinung Kvilhaugsvik 2 months ago

Sveinung, may these non-consuming actions (with 100% success chance) increase the veterancy of the agent?

My (quick) reading of server/diplomats.c says no.

I wanted to point it in case other similar actions may be exploited this way.

Bribe Unit can make a unit a veteran but it costs gold. A diplomatic battle can make the winner a veteran but both the attacker and the defender risks death. Escaping (to the nearest domestic city after performing a spy action) can make the unit a veteran but it dies if it doesn't manage to escape.

Also available in: Atom PDF