Project

General

Profile

Bug #657408

civ2civ3: sea unit help talks about ZOC

Added by Marko Lindqvist 5 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rulesets
Target version:
Start date:
Due date:
% Done:

0%


civ2civ3-no_sea_ZOC-trunk.patch View (1004 Bytes) David Fernandez (bard), 2017-05-05 03:17 PM

S2_6-civ2civ3-sea-zoc.patch View - S2_6 version (conflict in sandbox) (1.52 KB) Jacob Nevins, 2017-07-08 07:47 PM

History

#1 Updated by David Fernandez (bard) 5 months ago

My fault. I planned to enable ZOC for sea units in v2.6, but I do not like how sea units would affect movement of land units (and vice versa), so it is better we dissable it. I can do the patch.

#2 Updated by David Fernandez (bard) 5 months ago

This patch removes the ZOC flag from Sea unit class (that was not used anyway because ZOC was not enabled in oceanic tiles).
It keeps ZOC for Triremes that can navigate rivers and are affected by ZOC on purpose.
It includes same change for sandbox.

#3 Updated by Jacob Nevins 3 months ago

  • Target version changed from 2.6.0 to 2.6.0-beta1

#4 Updated by Jacob Nevins 3 months ago

  • Category changed from Documentation to Rulesets

#5 Updated by Jacob Nevins 3 months ago

Original words from gna bug #23361 (for the record):


jtn:

e.g., Frigate:

* Belongs to Sea unit class.
  * Subject to zones of control.
* May impose a zone of control on its adjacent tiles.

However, I don't think ZOC are in practice ever relevant for such units, due to water terrains having the NoZoc flag. (The only case where boats can be on land tiles, moving in and out of cities, is a special case for ZOC anyway.)

I think this is from patch #4818, where sea units were given ZOC so that a single-line ruleset change could enable naval ZOC in deep ocean.

While we could do something complicated to suppress the ZOC words for units only native to NoZoc terrain, the simpler thing would be to comment out all the sea unit ZOC stuff (with a greppable tag like NAVAL_ZOC so it can easily be added back in).

(Triremes have similar words, but they are genuinely relevant to Triremes due to river movement.)


cazfi:

the simpler thing would be to comment out all the sea unit ZOC stuff

Doesn't improve support for custom rulesets, though.

something complicated to suppress the ZOC words for units only native to NoZoc terrain,

We already do checking of native terrains in some situations, i.e., we have some tools for this, and there will be more in the future, i.e., additional tools made for this will be useful for other things in the future.


bard:

...where sea units were given ZOC so that a single-line ruleset change could enable naval ZOC in deep ocean.

Right, my plan was to enable zoc in deep ocean, but I have not played v2.6 yet, and I'm still not sure if it is a good idea or not.

Feel free to remove all the ZoC stuff related to sea units.

#6 Updated by Jacob Nevins 3 months ago

I think this is from patch #4818

(Apparently I meant gna patch #4816. 3ad18ed85c in git.)

#7 Updated by Jacob Nevins 3 months ago

S2_6 version attached.

#8 Updated by David Fernandez (bard) 3 months ago

David Fernandez (bard) wrote:

My fault. I planned to enable ZOC for sea units in v2.6, but I do not like how sea units would affect movement of land units (and vice versa), so it is better we dissable it. I can do the patch.

At this point, I have tested in v2.6 to enable ZoC for sea units in deep ocean (but not coastal ocean), and to give hasNoZoc flag to ancient sea units, and I'm liking the result. It will be included in my civ2civ3_earth modpack for v2.6, but I prefer to test it better before including it in official releases.

Feel free to remove all the ZoC stuff related to sea units.

I see ok to remove those lines for now.

#9 Updated by Jacob Nevins 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF