Project

General

Profile

Feature #685258

Enable zoom at level 2.0 in stable branches (S2_6 & S3_0)

Added by Marko Lindqvist 4 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
gui-gtk-3
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

It's better to partially enable gtk3- and gtk3.22-client zoom feature than keep it completely disabled. It should heva no "partial pixel" problems when zoom level is 2.0, so enable zoom feature that allows switching between zoom levels 1.0 and 2.0.

0002-Enable-zoom-at-level-2.0.patch (5.41 KB) 0002-Enable-zoom-at-level-2.0.patch Marko Lindqvist, 2017-07-22 10:03 PM
0005-Enable-zoom-at-level-2.0.patch (5.42 KB) 0005-Enable-zoom-at-level-2.0.patch S3_0 Marko Lindqvist, 2017-09-04 11:40 PM

Related issues

Related to Freeciv - Feature #685249: Port 'scale' feature to Gtk3 client?New

History

#1 Updated by Marko Lindqvist 4 months ago

#2 Updated by Jacob Nevins 4 months ago

#3 Updated by Marko Lindqvist 3 months ago

  • Target version changed from 2.6.0 to 2.6.0-beta2

#4 Updated by Marko Lindqvist 3 months ago

#5 Updated by Jacob Nevins 2 months ago

I am inclined to get this in in beta1 already.
In my testing, it seems like beta quality already, apart from bug #685277 which I'm looking at now; but even if I don't get a quick fix for most of that, I'd be happy to release with that as a known issue ("don't use city full bar") and bug #685279 too.
Or is there some reason this isn't ready? I'm running with it at the moment, FWIW.
I'd like to know what else is wrong with full zoom...

#6 Updated by Jacob Nevins 2 months ago

  • Target version changed from 2.6.0-beta2 to 2.6.0-beta1

it seems like beta quality already, apart from bug #685277 which I'm looking at now

I've now got a proposed fix for that (city full bar).

I intend for this patch (zoom enable) to go in 2.6.0-beta1, unless someone tells me it's a terribly bad idea.

One weakness that occurs to me is that I don't think we've tested a Windows msys1 Gtk3 build with zoom enabled, and the Cairo in use is still probably quite elderly. However, I think most of the zoom code is compiled in / activated regardless, and so the biggest risk is that enabling zoom x2 turns out not to work, not that the default x1 zoom is also broken? If so, I think that's an acceptable risk for a beta.

#7 Updated by Marko Lindqvist 2 months ago

Jacob Nevins wrote:

Or is there some reason this isn't ready? I'm running with it at the moment, FWIW.

I targeted beta2 mainly for having time to test and fix arising issues, but if you have tested it and consider it good enough for beta, ok.

#8 Updated by Marko Lindqvist 2 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF