Project

General

Profile

Bug #686635

Patrol Activity Icon does not use activity icon offset

Added by Griffon Spade 2 months ago. Updated about 11 hours ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Art
Target version:
Start date:
Due date:
% Done:

0%


Description

Results in it appearing way off to the upper left, at least in Hexemplio 2.6. Likely also in other versions.

0004-Document-what-icons-are-considered-Auto-for-activity.patch View - S2_6 - documentation part (1.16 KB) Marko Lindqvist, 2017-07-30 08:15 AM

0003-Document-what-icons-are-considered-Auto-for-activity.patch View - master, S3_0 - documentation part (1.12 KB) Marko Lindqvist, 2017-07-30 08:16 AM

0003-Hexemplio-Move-patrol-icon-to-unitextras.png.patch View (13.1 KB) Marko Lindqvist, 2017-08-04 02:33 PM

0005-Hexemplio-Locate-patrol-icon-like-autosettler-icon.patch View (13.3 KB) Marko Lindqvist, 2017-09-25 11:33 PM

History

#1 Updated by Marko Lindqvist 2 months ago

It's probably considered one of the "auto" icons README.graphics mentions:

  activity_offset_x    : Gives an offset from the tile origin at which to
  activity_offset_y      draw normal unit activity icons. "Auto" icons are not
                         affected by this as they are usually wanted in different
                         offset than real activity icons for both to appear simultaneously

If so, changing this in S2_6 would break d3f, so can only change hexemplio to not assume activity offset + make documentation clearer. In S3_0+ we can probably make patrol to use activity offset.

#2 Updated by Griffon Spade about 2 months ago

Moving it to Unit Extras png/spec for 2.6 would be the best way to handle it?

#3 Updated by Marko Lindqvist about 2 months ago

  • Target version set to 2.6.0

#5 Updated by Marko Lindqvist about 2 months ago

Griffon Spade wrote:

Moving it to Unit Extras png/spec for 2.6 would be the best way to handle it?

Yes

#6 Updated by Marko Lindqvist about 2 months ago

  • Blocks Task #656466: S3_0 datafile format freeze (d3f) added

#7 Updated by Griffon Spade about 2 months ago

Post with changed files for Hexemplio 2.6. (Unorganized)
[http://forum.freeciv.org/f/viewtopic.php?f=12&t=886&p=84714#p84714]

-commented patrol activity icon reference in activities.spec
-added patrol activity icon in unitextras.png
-added patrol activity icon reference in unitextras.spec

#8 Updated by Marko Lindqvist about 2 months ago

Document patch pushed

#9 Updated by Marko Lindqvist about 2 months ago

About S3_0 and later; The current behavior is correct in that in theory unit could have orders (-> show patrol icon) which would have also activity icon present. I don't think this ever happens with current clients, but for future compatibility it might be better to keep considering patrol icon one of the "Auto" icons.

I believe sveinung has been doing some work on orders stuff. Do you have such features planned that would make patrol icon and some activity icon to show at the same time?

#10 Updated by Marko Lindqvist about 2 months ago

Patch built from Griffon Spade's files. I plan to push this to all branches for now. We can revisit the issue for S3_0 and master later.

#11 Updated by Marko Lindqvist about 2 months ago

Current patch pushed, resolving the issue for S2_6 at least

#12 Updated by Sveinung Kvilhaugsvik about 2 months ago

Marko Lindqvist wrote:

I believe sveinung has been doing some work on orders stuff. Do you have such features planned that would make patrol icon and some activity icon to show at the same time?

I think the current order format already allows this. To create an order like that a hand edited savegame or a custom client would be needed. Example: a patrol that involves converting to a unit type that can pass some terrain and then convert back for other parts of the patrol.

#13 Updated by Marko Lindqvist about 2 months ago

Sveinung Kvilhaugsvik wrote:

a hand edited savegame

So scenario file could already use this feature. Then that hexemplio draws patrol icon to activity area and not to auto icon area is a bug.

#14 Updated by Marko Lindqvist 9 days ago

  • Category changed from Client to Art
  • Target version changed from 2.6.0 to 2.6.0-beta2

Marko Lindqvist wrote:

Then that hexemplio draws patrol icon to activity area and not to auto icon area is a bug.

This still needs changing even in S2_6.

#15 Updated by Marko Lindqvist 9 days ago

  • Blocks deleted (Task #656466: S3_0 datafile format freeze (d3f))

#16 Updated by Marko Lindqvist about 11 hours ago

Attached patch locates patrol icon to "Auto" icons space

Also available in: Atom PDF