Project

General

Profile

Feature #694097

Make expected steal depend on the action

Added by Sveinung Kvilhaugsvik about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Category:
General
Target version:
Start date:
Due date:
% Done:

100%

Estimated time:

Description

Stop using the "Spy" utype flag to signal that a unit can try to steal a tech from a city even when expected. Start using the action in stead. Rename "Steal Tech Escape" to "Steal Tech Escape Expected" and "Targeted Steal Tech Escape" to "Targeted Steal Tech Escape Expected" to reflect this.

Tech theft is expected when the number of previous tech thefts from the target city is above the limit set by the "Stealings_Ignore" effect. When tech theft is expected the difficulty of stealing a tech goes up. Certain units, like the classic ruleset's Diplomat unit, will always fail when this is the case.

The actions "Steal Tech Escape" and "Targeted Steal Tech Escape" was introduced in 3.0 to cover post steal escaping, an ability that used to depend on the "Spy" unit type flag. Have them cover expected theft too. Since this is done in 3.0 there is no backwards compatibility need to cover escape but always caught when expected. (Should any combination like that be wanted for 3.0 actions that cover them can be introduced in follow up patches.) Had this waited for 3.1 4 new actions would have been needed for backward compatibility.


Related issues

Blocks Freeciv - Feature #694112: "Spy" utype flag is dipl battle strength onlyClosed

Blocks Freeciv - Task #656466: S3_0 datafile format freeze (d3f)Closed2019-10-05

History

#2 Updated by Sveinung Kvilhaugsvik about 2 years ago

  • Blocks Feature #694112: "Spy" utype flag is dipl battle strength only added

#3 Updated by Marko Lindqvist about 2 years ago

Does this work without information leakage to the client in respect to the fact that client does not know how many times techs have been stolen from the target city, nor does it necessarily know current value of "Stealings_Ignore" for the target?

#4 Updated by Christian Knoke about 2 years ago

HostedRedmine.com wrote on Aug 30, 11:56 (+0000):

Issue #694097 has been updated by Marko Lindqvist.

#5 Updated by Christian Knoke about 2 years ago

[First attempt went wrong]

Just an idea, rel. to the information leakage: you might want the
information about stealing to be released, with a certain delay, let's say
of 3 turns, maybe, to the targeted player.

Reality aspect: most spionage actions are uncovered after some time.

Christian

--
Christian Knoke * * * http://cknoke.de
  • * * * * * * * * Ceterum censeo Microsoft esse dividendum.

#6 Updated by Sveinung Kvilhaugsvik about 2 years ago

Marko Lindqvist wrote:

Does this work without information leakage to the client in respect to the fact that client does not know how many times techs have been stolen from the target city, nor does it necessarily know current value of "Stealings_Ignore" for the target?

No information leakage is changed. This is about the actions them self, not about action enablers. I simply replaced the check for the "Spy" utype flag with a check for the "can be done even if more than leakage"-actions.

#7 Updated by Marko Lindqvist about 2 years ago

So client does not know which action it's really asking for?

#8 Updated by Sveinung Kvilhaugsvik about 2 years ago

Marko Lindqvist wrote:

So client does not know which action it's really asking for?

It is the same action no matter if the theft is expected or not. If the theft is expected and the action says the actor always is caught when the theft is expected the actor is caught. If the theft is expected and the action says the actor has a chance the actor has a chance. If the theft is unexpected the actor has a chance.

#9 Updated by Sveinung Kvilhaugsvik about 2 years ago

Needs savegame work.

#10 Updated by Marko Lindqvist about 2 years ago

  • Blocks Task #656466: S3_0 datafile format freeze (d3f) added

#12 Updated by Sveinung Kvilhaugsvik about 2 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 0 to 90

Closing.

Christian Knoke wrote:

[First attempt went wrong]

Just an idea, rel. to the information leakage: you might want the
information about stealing to be released, with a certain delay, let's say
of 3 turns, maybe, to the targeted player.

Reality aspect: most spionage actions are uncovered after some time.

This ticket doesn't involve information leakage. Not sure if I understood the comment. The current behavior is that both the thief and the victim is notified at once if a tech is stolen or a thief is caught. (The text giving this notice isn't remembered.) Please add your comment to Feature #657146 (or, if unrelated to it, as a new ticket) unless it is covered.

#13 Updated by Sveinung Kvilhaugsvik about 2 years ago

  • % Done changed from 90 to 100

Also available in: Atom PDF