Game/civilization info box popup has no background (gtk3.22)
The extended info box that pops up when clicking on the text above the "Turn done" button is drawn without a background, making the text hard to read (especially since there is other text behind it).
Discovered in Freeciv-2.6.0-beta0+c8cad4d8dd-msys2-win64-gtk3.22 on Windows 10 Home v1703 x64
This is Freeciv version 2.6.0-beta0-msys2 (beta version), gui-gtk-3.22 client.
Built against gtk+ 3.22.16, using 3.22.16
Built against glib 2.52.3, using 2.52.3
Probably strongly related to issue #656549
#1 Updated by Jacob Nevins 9 months ago
- bug #656549 was like this for the middle-click map popup
- removing gtk_widget_set_app_paintable() fixed that
- show_info_popup() is the only other instance of gtk_widget_set_app_paintable() in the Gtk3/3.22 clients
- I think this is the one you're referring to? Clicked text starts "Population: 10,000 ..." and popup starts "10,000 People ..."
Which suggests a fairly simple fix.
Attached a patch for S2_6; since I think my Gtk3 is too old to demonstrate the issue, I can't verify it resolves it, but it has no obvious ill effects for me. (And I haven't tested Gtk3.22 at all.)
If someone who can verify the fix wants to take over this ticket, feel free, otherwise I can commit it if someone verifies it actually helps.
#3 Updated by Marko Lindqvist 9 months ago
Jacob Nevins wrote:
I can commit it if someone verifies it actually helps.
Clearly the windows should not be set app_paintable, so maybe commit the patch in any case. Just leave this ticket open until it's confirmed with some build that it fixed this particular bug.