Middle-click popup and start position selection ignore effects like Output_Add_Tile
Feature #681980 notes that certain output-related tile effects do not show up in the middle-click tile popup, even if they are independent of city and player; civ2civ3's Nile flood effect is an obvious example.
This popup uses city_tile_output(), which can be called with a NULL pcity but in that case skips checking many effects (that in traditional rulesets were only used with a city/player requirement, but don't have to be).
This has been annoying me for ages. The attached patch fixes this.
Another notable user of this function is get_tile_value() called by create_start_positions(). Since that does look at the bonuses of mines and irrigation, it is likely to start liking Desert+River more in civ2civ3.
The same fix should in principle work on S2_5, and be useful there with civ2civ3. Arguably it's a bit risky for that branch. Setting target to 2.6.0 for now; maybe after some autogames and other experience we can backport it.
#2 Updated by Jacob Nevins 10 months ago
- File m-30-middle-click-output-effects.patch m-30-middle-click-output-effects.patch added
- File 26-middle-click-output-effects.patch 26-middle-click-output-effects.patch added
- File 25-middle-click-output-effects.patch 25-middle-click-output-effects.patch added
- Status changed from In Progress to Resolved
Now actually attached.
Commit candidate, pending autogame tests.