Project

General

Profile

Bug #694736

Middle-click popup and start position selection ignore effects like Output_Add_Tile

Added by Jacob Nevins 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
General
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Feature #681980 notes that certain output-related tile effects do not show up in the middle-click tile popup, even if they are independent of city and player; civ2civ3's Nile flood effect is an obvious example.

This popup uses city_tile_output(), which can be called with a NULL pcity but in that case skips checking many effects (that in traditional rulesets were only used with a city/player requirement, but don't have to be).

This has been annoying me for ages. The attached patch fixes this.

Another notable user of this function is get_tile_value() called by create_start_positions(). Since that does look at the bonuses of mines and irrigation, it is likely to start liking Desert+River more in civ2civ3.

The same fix should in principle work on S2_5, and be useful there with civ2civ3. Arguably it's a bit risky for that branch. Setting target to 2.6.0 for now; maybe after some autogames and other experience we can backport it.


Related issues

Related to Freeciv - Feature #681980: civ2civ3: use Mining_Pct for oil well, and Irrigation_Pct for desert flood.Closed

History

#1 Updated by Jacob Nevins 3 months ago

  • Related to Feature #681980: civ2civ3: use Mining_Pct for oil well, and Irrigation_Pct for desert flood. added

#2 Updated by Jacob Nevins 3 months ago

Now actually attached.

Commit candidate, pending autogame tests.

#3 Updated by Jacob Nevins 3 months ago

No divergence in my S2_6 civ2civ3 autogame before I had to kill the control run (T4378). The run with this change ran to T5000 without obvious trouble.

Thus, I intend to commit this to S2_6+.

#4 Updated by Jacob Nevins 3 months ago

  • Status changed from Resolved to Closed

#5 Updated by Jacob Nevins 3 months ago

Will reopen if I decide to push the S2_5 backport.

Also available in: Atom PDF