Project

General

Profile

Feature #695978

civ2civ3: simplify Super Highways by always giving city center trade

Added by Jacob Nevins 17 days ago. Updated 15 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rulesets
Target version:
Start date:
Due date:
% Done:

0%


Description

As suggested by bard in bug #695976:

Currently, Super Highways' trade bonus is disabled for tiles with a farmland bonus. This is simple in concept but complicated in implementation for city centers, which can get an implicit farmland bonus.

bard says: "In my games, superhighways always give 1 extra trade on the central city tile, even when there is a farmland, and I personally like it."

m-30-civ2civ3-superhighways-simplify.patch View (10.3 KB) Jacob Nevins, 2017-09-09 03:52 PM

26-civ2civ3-superhighways-simplify.patch View (10.3 KB) Jacob Nevins, 2017-09-09 03:52 PM

26-civ2civ3-superhighways-simplify-2.patch View (10.4 KB) Jacob Nevins, 2017-09-10 07:50 AM

m-30-civ2civ3-superhighways-simplify-2.patch View (10.4 KB) Jacob Nevins, 2017-09-10 07:50 AM


Related issues

Related to Freeciv - Bug #695976: civ2civ3: Super Highways corner cases (too much trade bonus) Rejected
Blocks Freeciv - Task #694704: civ2civ3: introduce new features for 2.6 Closed

History

#1 Updated by Jacob Nevins 17 days ago

  • Related to Feature #695972: Add civ2civ3's tech_cost_style to engine added

#2 Updated by Jacob Nevins 17 days ago

  • Related to deleted (Feature #695972: Add civ2civ3's tech_cost_style to engine)

#3 Updated by Jacob Nevins 17 days ago

  • Related to Bug #695976: civ2civ3: Super Highways corner cases (too much trade bonus) added

#4 Updated by Jacob Nevins 17 days ago

superhighways always give 1 extra trade on the central city tile, even when there is a farmland

I've interpreted this as, only if the city center tile is giving any trade at all (as on other tiles).
(And only if it has a road, but with modern civ2civ3 I think it's impossible not to.)

#5 Updated by David Fernandez (bard) 17 days ago

I like the way you implemented it.
But one of the effects comments is confusing, I think you forgot to remove it from previous version:

; City without Supermarket doesn't get farmland bonus => can get trade bonus

#6 Updated by Jacob Nevins 16 days ago

Oops. Fixed. Thanks for review.

#7 Updated by Jacob Nevins 16 days ago

  • Blocks Task #694704: civ2civ3: introduce new features for 2.6 added

#8 Updated by Jacob Nevins 15 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF