Project

General

Profile

Bug #697658

Minimap not redrawn often enough

Added by Jacob Nevins about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
gui-gtk-3
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In the Gtk3 client (S2_5 and S2_6), on a new game, if I go into the editor, select the vision tool, increase its size, and click on the map to reveal a large swath of territory, the minimap isn't updated until I right-click on the main map or minimap to scroll.

This works as I expect in the Gtk2 client.

I haven't checked if similar effects are visible in the game (the map editor being an easy way to cause large changes visible on the minimap).

gtk3_overview_flush.patch (366 Bytes) gtk3_overview_flush.patch Gna file #29445: gtk3_overview_flush.patch added by mir3x (from gna bug #25318, 2016-11-20, for S2_5) Jacob Nevins, 2017-09-17 10:23 AM
gtk3_overview_flush-26-trunk.patch (735 Bytes) gtk3_overview_flush-26-trunk.patch gna file #29446: gtk3_overview_flush-26-trunk.patch added by mir3x (from gna bug #25318, 2016-11-20, for S2_6/trunk as was) Jacob Nevins, 2017-09-17 10:24 AM
m-gtk3-overview-flush.patch (1.36 KB) m-gtk3-overview-flush.patch Rebase against master (+ gui-gtk-4.0) Jacob Nevins, 2017-09-17 10:30 AM

History

#1 Updated by Christian Knoke about 1 year ago

HostedRedmine.com wrote on Sep 17, 09:50 (+0000):

Issue #697658 has been reported by Jacob Nevins.

I haven't checked if similar effects are visible in the game (the map
editor being an easy way to cause large changes visible on the minimap).

This is the case (bug present in 2.6 Beta as of yesterday) and reported to
GNA months ago.

Christian

--
Christian Knoke * * * http://cknoke.de
  • * * * * * * * * Ceterum censeo Microsoft esse dividendum.

#2 Updated by Jacob Nevins about 1 year ago

Ah yes.

You reported it in gna bug #24082 "Map Update Bugs" among some other symptoms:

Vers. 2.5.1 Gtk3 cpmpiled from source, multiplayer, one-human game

In some cases, the map or the minimap is not updated correctly.
In all cases, the (mini)map display is corrected, if I right-click on a non-central spot of the main map (but maybe not by right-click in the minimap).

...

2 At the beginning of a new turn, units on minimap are not correct
at the beginning of a new turn, the minimap shows units (in red) that are not on the main map, been killed in the turn before, and are correctly not shown on the main map.

mir3x responded:

Attached patch fixes minimap issues.
It works the same way like in qt.

get_overview_window() is invoked when overview has changed and before redrawing to overview surface - which doesnt exist in gtk3.
Beacause overivew is drawn directly from gui_options.overview.window.

So making update during get_overview_window() is 100% accurate.

ML feel free to check and commit if u like.

There was some faff and I raised a more specific bug #25318 "Gtk3 client minimap doesn't update":

The Gtk3 minimap is often out of date. It only seems to update when the whole map is recentred.
  • Moving units don't change the fogged areas, unit pixels, etc
  • Using vision tool in editor doesn't update minimap

Seen in current (2.5.6) S2_5, and I've freshly confirmed it goes back at least as far back as 2.5.1.
chrisk previously reported this as part of bug #24082, and mir3x diagnosed the problem there (and wrote a patch?)

#3 Updated by Jacob Nevins about 1 year ago

This patch solves the problem for me in gui-gtk-3.0.

No sense sitting on mir3x's patch any longer; I intend to commit it.

I haven't tested gui-gtk-3.22 or -4.0, I'm just trusting that the fix is the right thing to do in those versions too.

#4 Updated by Jacob Nevins about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF