Bug #700913: Windows COPYING.installer - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #700913

Windows COPYING.installer

Added by frank e over 4 years ago. Updated 2 months ago.

Status:

Closed

Priority:

Low

Assignee:

Marko Lindqvist

Category:

Windows Installers

Sprint/Milestone:

3.0.2

Start date:

Due date:

% Done:

Estimated time:

Description

Double fault near .../doc/freeciv/installer/COPYING.installer:

This could go to .../doc/freeciv/COPYING.installer together
with all other licenses (so far limited to a GPL in COPYING).
At the moment COPYING.installer is another copy of the GPL,
it should be the NSIS license with the relevant LZMA credits.

There should be also proper ZLIB, PNG, ICU, etc. credits and
licenses somewhere.  Maybe the best fix would be to rename
doc/freeciv/installer to doc/freeciv/licenses and collect all
credits there, inspired by the ffmpeg/licenses collection.

0002-Windows-installers-Construct-license-file-dynamicall.patch (42.9 KB) 0002-Windows-installers-Construct-license-file-dynamicall.patch		Marko Lindqvist, 2022-04-08 02:32 AM
0013-Windows-installers-Construct-license-file-dynamicall.patch (42.2 KB) 0013-Windows-installers-Construct-license-file-dynamicall.patch	S3_0	Marko Lindqvist, 2022-04-08 05:44 AM
0023-Windows-installers-Construct-license-file-dynamicall.patch (43.6 KB) 0023-Windows-installers-Construct-license-file-dynamicall.patch	master	Marko Lindqvist, 2022-04-11 01:56 AM
0017-Windows-installers-Construct-license-file-dynamicall.patch (43.6 KB) 0017-Windows-installers-Construct-license-file-dynamicall.patch	master	Marko Lindqvist, 2022-04-12 06:52 AM
0015-Windows-installers-Construct-license-file-dynamicall.patch (44.4 KB) 0015-Windows-installers-Construct-license-file-dynamicall.patch		Marko Lindqvist, 2022-04-13 04:54 AM

History

#1 Updated by Marko Lindqvist over 4 years ago

COPYING.installer is a freeciv license that installer shows.

#2 Updated by frank e over 4 years ago

Marko Lindqvist wrote:

COPYING.installer is a freeciv license that installer shows.

Ugh, can't it show COPYING instead of installer/COPYING.installer ? It's the same GPL. ;-)

#3 Updated by Marko Lindqvist over 4 years ago

frank e wrote:

Marko Lindqvist wrote:

COPYING.installer is a freeciv license that installer shows.

Ugh, can't it show COPYING instead of installer/COPYING.installer ? It's the same GPL. ;-)

It has additional text on top.

#4 Updated by Marko Lindqvist over 1 year ago

Sprint/Milestone changed from 3.0.0-beta1 to 3.0.0-beta2

#5 Updated by Marko Lindqvist about 1 year ago

Sprint/Milestone changed from 3.0.0-beta2 to 3.0.0-beta3

#6 Updated by Marko Lindqvist 9 months ago

Sprint/Milestone changed from 3.0.0-beta3 to 3.0.0

#7 Updated by Marko Lindqvist 5 months ago

Sprint/Milestone changed from 3.0.0 to 3.0.1

#8 Updated by Marko Lindqvist 3 months ago

Sprint/Milestone changed from 3.0.1 to 3.0.2

I've kept this ticket targeted always to the next release with the idea that maybe we could use the main COPYING (like frank suggested), and just somehow add the header, instead of carrying separate COPYING.installer file.

#9 Updated by Marko Lindqvist 3 months ago

File 0002-Windows-installers-Construct-license-file-dynamicall.patch 0002-Windows-installers-Construct-license-file-dynamicall.patch added
Status changed from New to In Progress

Attached patch made for master, to test. It doesn't improve the situation lot, as the installer is able to show ready-constructed files only, but at least this should allow us not to keep the file in version control - it's constructed dynamically before building the installer.

#10 Updated by Marko Lindqvist 3 months ago

File 0013-Windows-installers-Construct-license-file-dynamicall.patch 0013-Windows-installers-Construct-license-file-dynamicall.patch added
Category changed from Documentation to Windows Installers
Status changed from In Progress to Resolved
Assignee set to Marko Lindqvist

Marko Lindqvist wrote:

Attached patch made for master, to test. It doesn't improve the situation lot, as the installer is able to show ready-constructed files only, but at least this should allow us not to keep the file in version control - it's constructed dynamically before building the installer.

It passed initial testing + it applies to S3_1.

Separate patch for S3_0 attached.