HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Bug #705580
Caravan can help building Palace
0%
Description
I first noticed that S3_0 and master rulesets explicitly introduce action enabler for helping building small wonders; that's Palace in default rulesets. Certainly that's not correct.
It seems this has been the case as long as concept of Small Wonders has existed. When they were introduced the help wonder code was not adjusted at all - it just uses is_wonder() to check if target is valid. In S2_0 is_wonder() means only Great Wonders, and Palace isn't one. In S2_1 is_wonder() means both Great and Small Wonders, and Palace is latter.
In S3_0/master fixing this can happen in rulesets, S2_6 seems to require fix hardcoded to the engine.
Related issues
History
#1
Updated by Marko Lindqvist almost 4 years ago
Maybe we should review all is_wonder() calls to see which ones should be is_great_wonder() instead. I now noticed that also buy_cost is doubled for small wonders (this might be what some rulesets with real small wonders want, but likely not what should happen to almost-regular building like Palace)
#2
Updated by Marko Lindqvist almost 4 years ago
#3
Updated by Jacob Nevins almost 4 years ago
Will we fix this in 2.6?
(I've no objection, it seems like a reasonable change in the beta phase)
#4
Updated by Marko Lindqvist over 3 years ago
- File 0004-Disallow-units-from-helping-building-of-small-wonder.patch 0004-Disallow-units-from-helping-building-of-small-wonder.patch added
- Sprint/Milestone changed from 2.6.0 to 2.6.0-beta3
S2_6 version
#5
Updated by Marko Lindqvist over 3 years ago
- Blocks Task #700704: S3_0 alpha1 added
#6
Updated by Marko Lindqvist over 3 years ago
- File 0040-Disallow-units-from-helping-building-of-small-wonder.patch 0040-Disallow-units-from-helping-building-of-small-wonder.patch added
- File 0005-Disallow-units-from-helping-building-of-small-wonder.patch 0005-Disallow-units-from-helping-building-of-small-wonder.patch added
- Category set to Rulesets
master & S3_0 versions with just ruleset changes.
#7
Updated by Marko Lindqvist over 3 years ago
- Status changed from New to Closed
- Assignee set to Marko Lindqvist
#8
Updated by Jacob Nevins over 3 years ago
On reflection, this is presumably a big change for the 'multiplayer' ruleset, where most wonders are small.
I wonder if we should postpone this to 3.0, where this behaviour can be under ruleset control?
#9
Updated by Jacob Nevins over 3 years ago
- Related to Bug #745360: Disallowing caravans from helping small wonders breaks multiplayer ruleset added
#10
Updated by Jacob Nevins over 3 years ago
I wonder if we should postpone this to 3.0, where this behaviour can be under ruleset control?
-> bug #745360
.