Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #705580

Caravan can help building Palace

Added by Marko Lindqvist over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Rulesets
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I first noticed that S3_0 and master rulesets explicitly introduce action enabler for helping building small wonders; that's Palace in default rulesets. Certainly that's not correct.

It seems this has been the case as long as concept of Small Wonders has existed. When they were introduced the help wonder code was not adjusted at all - it just uses is_wonder() to check if target is valid. In S2_0 is_wonder() means only Great Wonders, and Palace isn't one. In S2_1 is_wonder() means both Great and Small Wonders, and Palace is latter.

In S3_0/master fixing this can happen in rulesets, S2_6 seems to require fix hardcoded to the engine.


Related issues

Related to Freeciv - Bug #745360: Disallowing caravans from helping small wonders breaks multiplayer rulesetClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Freeciv - Task #700704: S3_0 alpha1Closed2018-03-162018-03-16

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist over 3 years ago

Maybe we should review all is_wonder() calls to see which ones should be is_great_wonder() instead. I now noticed that also buy_cost is doubled for small wonders (this might be what some rulesets with real small wonders want, but likely not what should happen to almost-regular building like Palace)

#2 Updated by Marko Lindqvist over 3 years ago

Marko Lindqvist wrote:

I now noticed that also buy_cost is doubled for small wonders

-> Bug #706727

#3 Updated by Jacob Nevins about 3 years ago

Will we fix this in 2.6?

(I've no objection, it seems like a reasonable change in the beta phase)

#5 Updated by Marko Lindqvist about 3 years ago

#7 Updated by Marko Lindqvist about 3 years ago

  • Status changed from New to Closed
  • Assignee set to Marko Lindqvist

#8 Updated by Jacob Nevins about 3 years ago

On reflection, this is presumably a big change for the 'multiplayer' ruleset, where most wonders are small.

I wonder if we should postpone this to 3.0, where this behaviour can be under ruleset control?

#9 Updated by Jacob Nevins about 3 years ago

  • Related to Bug #745360: Disallowing caravans from helping small wonders breaks multiplayer ruleset added

#10 Updated by Jacob Nevins about 3 years ago

I wonder if we should postpone this to 3.0, where this behaviour can be under ruleset control?

-> bug #745360

Also available in: Atom PDF