HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Gtk3 client gratuitously scrolls worklist dialog
A friend reports:
In the Gtk3 client's city dialog, when you double-click an item on "source tasks" to add it to the worklist, the "Source Tasks" window is scrolled to put the thing you clicked on near the top. Gtk2 didn't do this. It's irritated them enough that they've gone back to Gtk2.
#4 Updated by Jacob Nevins almost 2 years ago
- File m-gtk-worklist-no-rebuild.patch m-gtk-worklist-no-rebuild.patch added
- File 30-26-gtk-worklist-no-rebuild.patch 30-26-gtk-worklist-no-rebuild.patch added
- Status changed from New to Resolved
- Assignee set to Jacob Nevins
refresh_worklist() gets called, and that completely tears down and rebuilds the source task list. (It does the same on Gtk2, so I'm surprised that doesn't suffer from the problem; you can see the scrollbar flicker a bit on Gtk2 though.)
Attached patch takes the same approach as is taken for the worklist proper (which doesn't suffer from this problem) -- reuse existing items for the new list, creating and deleting items at the end as necessary. (On all Gtk clients, even Gtk2, on general principles.)
(That approach came in for the worklist proper in commit f74676cda8 in 2003 -- it's not stated that this is why it was done this way though.)
Testing doesn't show any obvious regressions. (The source list doesn't reliably update when a new tech is discovered, but that's a pre-existing bug, not new with this patch.)