Project

General

Profile

Bug #707595

Part II of the "now valid" SVG flags in Gna! patch #7393

Added by frank e almost 2 years ago. Updated over 1 year ago.

Status:
In Progress
Priority:
Normal
Assignee:
-
Category:
Nations
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Part II of Gna! patch #7393 contained 40 "now valid" SVG flags copied from commons. This means they might be visually different, and if I think that's the case I add a note, because it would require new PNGs (flags + shields in two sizes).

Otherwise please check the flag on the Wiki, the link goes directly to the #Licensing section before the file history, and the file history shows a thumbnail of the freshest version before the thumbnails of older versions for a visual comparison.

In almost all cases the license will be now PD (or CC0), otherwise I add a note. An older invalid flag contributed by uvw with license GPLv2 or similar is not the same thing as a new valid SVG flag contributed by xyz to the public domain.

History

#1 Updated by frank e almost 2 years ago

usa.svg was GNAPATCH#7393

Visually different, needs new PNGs. Gna!#7481 is now covered by #706407. Gna!#7479 is now covered by #707576.

manchuria.svg was GNAPATCH#7470

Visually different, maybe it was just completely broken and does not need new PNGs.

united nations.svg was GNAPATCH#7460

Visually changed.

tibet.svg was GNAPATCH#7459

spain.svg was GNAPATCH#7458

fiji.svg was GNAPATCH#7457

Visually different, requires a manual recreation of the shields.

equatorial guinea.svg was GNAPATCH#7456

Visually different, requires a manual recreation of the shields.

#2 Updated by frank e almost 2 years ago

el salvador.svg was GNAPATCH#7455

croatia.svg was GNAPATCH#7454

Visually different.

costa rica.svg was GNAPATCH#7453

Visually different, certainly not one of the 2017 versions on commons, but they are all visually different, and I don't care about their edit wars if I can grab a good Sibr4.

canada old.svg was GNAPATCH#7451

Visually different.

california.svg was GNAPATCH#7450

Visually different, also used in two bear images for the animal kingdom.

newzealand.svg was GNAPATCH#7400

Visually different.

trebizond.svg was GNAPATCH#7397

Was completely broken (no display on the Wiki), maybe the PNGs are still okay.

turkey.svg was GNAPATCH#7396

#3 Updated by frank e almost 2 years ago

brunei.svg was GNAPATCH#7449

Visually different.

argentina.svg was GNAPATCH#7448

Visually different.

andorra.svg was GNAPATCH#7447

belize.svg was GNAPATCH#7446

Visually different.

alsace.svg was GNAPATCH#7445

bolivia.svg was GNAPATCH#7444

Visually different.

brasil.svg was GNAPATCH#7443

Visually different.

assyria.svg was GNAPATCH#7442

Visually different.

#4 Updated by frank e almost 2 years ago

southern sudan.svg was GNAPATCH#7441

Visually different.

ethiopia.svg was GNAPATCH#7440

Visually different.

cheyenne.svg was GNAPATCH#7424

Visually different.

esperanto.svg was GNAPATCH#7423

algeria.svg was GNAPATCH#7421

afghanistan.svg was GNAPATCH#7420

Visually different (the CoA is apparently different).

vietnam.svg was GNAPATCH#7419

Maybe not exactly the same red.

palestine.svg was GNAPATCH#7418

Visually different.

#5 Updated by frank e almost 2 years ago

norway.svg was GNAPATCH#7417

Visually different.

korea.svg was GNAPATCH#7416

Visually different.

pirate.svg was GNAPATCH#7409

mauritania.svg was GNAPATCH#7409

sudan.svg was GNAPATCH#7406

latvia.svg was GNAPATCH#7404

Visually different.

lithuania.svg was GNAPATCH#7403

Visually different.

sao tome and principe.svg was GNAPATCH#7402

Very different, the old flag was broken, maybe the PNGs are still good.

#6 Updated by frank e almost 2 years ago

Summary, strike almost in almost all PD, even the Pirates are PD. While at it I undid an erroneous self-revert back to the intended commons version of sudan.svg and got a meanwhile fixed + current norway.svg from commons, instead of the also valid archived commons version.

#7 Updated by Marko Lindqvist almost 2 years ago

Patch for usa flag. Will commit these one by one as soon as 36h has passed since they were attached to this ticket.

#8 Updated by frank e almost 2 years ago

Marko Lindqvist wrote:

Patch for usa flag. Will commit these one by one as soon as 36h has passed since they were attached to this ticket.

Just in case, some SVGs here (and both in #707576) need new PNGs. Does the existing make flags+shields from SVG script still work for you? Looking again at it, apparently it creates new PNGs if they are missing or older than the SVG, so far that can't be wrong.

In theory I could create new patches for these SVGs (latest+greatest on the Wiki vs. whatever is on GitHub), but I don't see the point, in almost all cases the complete SVG was replaced, no old lines kept as is.

XML is not really about lines and not really suited for diff, unless you stumble about a comment (on the Wiki) in the direction of "fixed SVG syntax with a text editor to make the validator happy". Generally I tried "copy wholesale from commons" or "garbage in, valid out, with rsvg-convert", and after those procedures a diff is hopeless.

#9 Updated by Marko Lindqvist almost 2 years ago

frank e wrote:

Does the existing make flags+shields from SVG script still work for you?

That's what I've used when creating the patches.

new patches for these SVGs (latest+greatest on the Wiki vs. whatever is on GitHub), but I don't see the point, in almost all cases the complete SVG was replaced, no old lines kept as is.

Git patches are what gets applied to git. For human readability the binary (png) parts of the patches are even less useful.

#10 Updated by Daniel Markstedt almost 2 years ago

Marko Lindqvist wrote:

frank e wrote:

Does the existing make flags+shields from SVG script still work for you?

That's what I've used when creating the patches.

The script works for me too, although I had to hack it slightly to work with Inkscape on macOS. See: #715161 . What problem are you running in to?

Also, for the record: The new USA flag committed in this ticket isn't 2:3 aspect ratio but rather 10:19. This renders into a 29x16px small flag bitmap image, which is inconsistent with the 29x20 px flag images that all the other 2:3 svg images are producing. Please consider resizing the image for a more consistent look in-game.

#11 Updated by frank e almost 2 years ago

Daniel Markstedt wrote:

Also, for the record: The new USA flag committed in this ticket isn't 2:3 aspect ratio but rather 10:19.

Without checking the details, if 19 is the width that could be something like 380 pixels, and to get 300x200 you can remove 80 pixel columns on the right side before the various scaling + shield masking procedures.

As long as the PNGs are newer than the SVG make wouldn't try to create new PNGs where the script doesn't automatically produce 2:3. With that you can cheat, just touch the old PNGs to be newer than the new "now valid" SVG, if any visual color improvements/differences are not really relevant for Freeciv.

For details how any SVG can be converted to exactly the wanted PNG sizes see a forum post

#12 Updated by Jacob Nevins over 1 year ago

  • Target version deleted (2.6.0-beta2)

#13 Updated by Jacob Nevins over 1 year ago

Also, for the record: The new USA flag committed in this ticket isn't 2:3 aspect ratio but rather 10:19.

Rats, didn't remember to submit a patch to revert the USA flag in time, but I don't want a regression in 2.6.0-beta2.

I intend to revert commit:6853b0fc77 (S2_6) and other branch equivalents. I intend to do this before beta2 release tomorrow, even though it's only a few hours away.

Also available in: Atom PDF