Project

General

Profile

Bug #708934

Four allegedly "off by one" PNGs

Added by frank e almost 3 years ago. Updated about 1 year ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Nations
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This was Gna! #24465 and also is the last of my old -crap-nits remotely related to flags:

cuyavia.png 29x19 instead of 29x20 
jaffna.png 29x21 instead of 29x20 
keetoowah.png 29x22 instead of 29x20 
vampire.png 29x21 instead of 29x20 

The original bug report was triggered by an attempt to determine the predominant colour for all flags as far as they have a predominant colour, for the new (as of 2.5, IIRC) plrcolormode NATION_ORDER, but I dropped it as fundamentally flawed idea, e.g., "NATO blue" for the natives was just wrong.

The "off by one" observation might be also wrong, i.e., the four old flags obviously worked as they should, but all other flags use 29x20, and maybe consistency could be a good thing:

cuyavia.png

"jaffna.png"+"keetoowah.png"+"vampire.png": Sorry, we had to truncate this directory to 1,000 files. 1,846 entries were omitted from the list. Meh

"

cuyavia.png (123 Bytes) cuyavia.png frank e, 2017-11-03 01:45 AM
jaffna.png (1.31 KB) jaffna.png frank e, 2017-11-03 01:46 AM
keetoowah.png (1.1 KB) keetoowah.png frank e, 2017-11-03 01:46 AM
vampire.png (330 Bytes) vampire.png frank e, 2017-11-03 01:46 AM

History

#1 Updated by frank e almost 3 years ago

crapnits was what I wanted to write.

#2 Updated by Marko Lindqvist about 1 year ago

Those dimensions are what ./convert_png produces from the .svgs. I assume it's because those .svgs do not have 29x20 ratio.

Also available in: Atom PDF