Project

General

Profile

Bug #723052

Don't use nonexistent event E.TUTURIAL in tutorial scenario

Added by Jacob Nevins 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

From bug #721462:

The script embedded in the tutorial scenario has this in city_growth_callback near (but not at) the 157th line:

    elseif size == 13 and not growth13msg then
      notify.event(city.owner, city.tile, E.TUTURIAL, ...

Note the typo "TUTURIAL" instead of "TUTORIAL". Neither event type exists; other parts of the script use "E.SCRIPT" instead.

How I think this came about:
  • The typo E.TUTURIAL has been present since the tutorial was added (r10468, PR#7245, 2005).
  • r16036 / gna bug 14221 (2009) renamed E.TUTORIAL to E.SCRIPT; I guess it used a simple search-and-replace and thus left the typo'd version behind.

Related issues

Related to Freeciv - Bug #721462: Lua error messages in the tutorialBlocked

History

#1 Updated by Jacob Nevins 6 months ago

Patches attached to bug #721462.

#2 Updated by Jacob Nevins 6 months ago

  • Status changed from Resolved to Closed

#3 Updated by Jacob Nevins 6 months ago

  • Related to Bug #721462: Lua error messages in the tutorial added

Also available in: Atom PDF