Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #734377

Messages when making bombard attacks

Added by James Wilson over 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Low
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:
2.00 h

Description

When you make a bombard attack (currently only bomber it stealth bomber in standard rulesets) there is no message sent to attacker or defender.

There should be a simple one provided - no details on HP etc, to tie in with the messages for standard attacks.


Related issues

Related to Freeciv - Feature #734544: Rename E_UNIT_WIN as E_UNIT_WIN_DEFClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by James Wilson over 3 years ago

Hi, this is my first (albeit small) contribution to Freeciv! (and any project other than documentation)
Thank you for the help on #freeciv, jtn and cazfi.

It adds notification for bombard attacks which was missing - please let me know if I've done anything wrong with the process or the style, although I've tried to follow the style of the surrounding code as much as possible.

James

#2 Updated by Marko Lindqvist over 3 years ago

  • Status changed from New to In Progress

With maximum nitpicks, so you don't learn any bad habits from the beginning:
- TRANS comments lack ':' > "TRANS: ..."
Commit message should be in imperative: "Show messages..."
- Commit message should mention the hrm ticket, e.g., "See hrm Feature #734377"
- Doesn't apply to S2_6, apparently you need to make two patches; one for master & S3_0, one for S2_6
- Applying patch gives "trailing whitespace errors" from the last couple of lines

Can you fix these and submit a new version?

#3 Updated by Marko Lindqvist over 3 years ago

We have separate message types for attacking and defending, so the two messages you have should not have the same message type. Please check which one needs changing and to what.

#4 Updated by Marko Lindqvist over 3 years ago

#5 Updated by James Wilson over 3 years ago

Hi Mark thanks for the feedback - I was unsure about the message types - went with WIN because neither of them die!

Thanks for the nitpicking will resubmit soon :-)

James

#6 Updated by James Wilson over 3 years ago

Hi just an update - real world stuff has intervened, but I still intend to do this!
James

#7 Updated by James Wilson over 3 years ago

Hi - these patches should work now and have taken your feedback on board. In the S2_6 branch, trimming all the trailing whitespace from the file resulted in changes everywhere - so I've left this (my changes have no trailing whitespace though :-) )

Again, this is my first patch so if I've done it wrong, please let me know:)

#8 Updated by Marko Lindqvist over 3 years ago

James Wilson wrote:

trimming all the trailing whitespace from the file resulted in changes everywhere - so I've left this (my changes have no trailing whitespace though :-) )

Yes, the idea was only that whitspaces should be removed from the lines you touch or add. Git complains about those when you apply the patch file.

#9 Updated by James Wilson over 3 years ago

One of these patches has got unrelated whitespace changes in - not sure how it's happened, will fix

#10 Updated by Marko Lindqvist over 3 years ago

I'm about to push Feature #734544 soon, which will require updating this patch, I think.

#11 Updated by Jacob Nevins about 3 years ago

  • Sprint/Milestone changed from 2.6.0 to 2.6.1

#12 Updated by Marko Lindqvist almost 3 years ago

  • Due date deleted (2018-02-27)
  • Start date deleted (2018-02-20)

#13 Updated by Marko Lindqvist over 2 years ago

Is there a new version of the patch coming?

#14 Updated by Marko Lindqvist over 2 years ago

- Fixed indentation in branches
- Updated S3_0/master patch to apply to HEAD

#15 Updated by Marko Lindqvist over 2 years ago

  • Status changed from Resolved to Closed

#16 Updated by James Wilson about 2 years ago

Hi - I'm really sorry but I haven't been able to make one and won't be able
to for the foreseeable future - combination of childcare, moving house and
changing careers!

Sorry - and thank you for the help!

On Sat, 9 Feb 2019, 19:42 HostedRedmine.com <
wrote:

Issue #734377 <http://www.hostedredmine.com/issues/734377#change-1739174>
has been updated by Marko Lindqvist.
------------------------------

Is there a new version of the patch coming?
------------------------------
Feature #734377: Messages when making bombard attacks
<http://www.hostedredmine.com/issues/734377#change-1739174>

- *Author: *James Wilson
- *Status: *In Progress
- *Priority: *Low
- *Assignee: *James Wilson
- *Category: *Server
- *Target version: *2.6.1

When you make a bombard attack (currently only bomber it stealth bomber in
standard rulesets) there is no message sent to attacker or defender.

There should be a simple one provided - no details on HP etc, to tie in
with the messages for standard attacks.
Files 0001-Shows-messages-for-bombarding.patch
<http://www.hostedredmine.com/attachments/download/271568/0001-Shows-messages-for-bombarding.patch>
(1.47 KB)
0001-Master-Display-messages-when-bombarding-units-or-being-bomb.patch
<http://www.hostedredmine.com/attachments/download/272939/0001-Master-Display-messages-when-bombarding-units-or-being-bomb.patch>
(7.8 KB)
0001-S2_6-Display-messages-when-bombarding-units-or-being.patch
<http://www.hostedredmine.com/attachments/download/272940/0001-S2_6-Display-messages-when-bombarding-units-or-being.patch>
(1.5 KB)
------------------------------

You can reply to this email and it will be added to the issue log within a
few minutes.

You have received this notification because you have either subscribed to
it, or are involved in it.
To change your notification preferences, please click here:
http://www.hostedredmine.com/my/account

Also available in: Atom PDF