Bug #741552
governments.ruleset "ruler_titles" documentation
0%
Description
Supplied governments.rulesets speaks of nation specific ruler_titles as if it was part of government ruleset object. The default titles that ARE part of government object are not documented. This needs to be updated.
History
#1
Updated by Sim Sulla about 2 years ago
I don't understand this issue. The governments.ruleset has no ruler_titles (it has female and male title). The nations.ruleset has by gov type.
Should ruler_titles = "XYZ" be added to each government type in governments.ruleset?
#2
Updated by Marko Lindqvist about 2 years ago
The documentation (comments in rulesets) should be updated to match the implementation.
#3
Updated by Marko Lindqvist about 2 years ago
- Target version set to 2.6.0
There's an proposed fix by simsulla at https://github.com/freeciv/freeciv/pull/10
- data/ruledit/comments.txt is not updated
- The part that default titles are not documented is not fixed
#4
Updated by Sim Sulla about 2 years ago
Fixed the data/ruledit/comments.txt.
Isn't the default ruler title documented as "ruler_male_title = _("King %s")" etc?
#5
Updated by Jacob Nevins about 2 years ago
- Status changed from New to In Progress
#6
Updated by Jacob Nevins almost 2 years ago
- Target version changed from 2.6.0 to 2.6.1
#7
Updated by Marko Lindqvist about 1 year ago
- File 0011-Correct-ruler-title-documentation-in-government.rule.patch 0011-Correct-ruler-title-documentation-in-government.rule.patch added
- File 0003-Correct-ruler-title-documentation-in-government.rule.patch 0003-Correct-ruler-title-documentation-in-government.rule.patch added
- Status changed from In Progress to Resolved
Patches I've made from scratch.
#8
Updated by Marko Lindqvist about 1 year ago
- File 0001-Correct-ruler-title-documentation-in-government.rule.patch 0001-Correct-ruler-title-documentation-in-government.rule.patch added
- Target version changed from 2.6.1 to 2.5.12
#9
Updated by Marko Lindqvist about 1 year ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist