HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. "Read more...":https://support.plan.io/news/187
Bug #763061
closedDocument that Worker, Settler, and Engineer in a city don't get defend bonus
0%
Description
2.6.0-RC1 classic ruleset
Their Defense strength doesn't change whether they are in a city or not.
Files
Related issues
Updated by Marko Lindqvist over 4 years ago
Have they got that bonus in some older version? It's an automatic fortification bonus, and those units cannot (in classic ruleset) fortify, so I think they should not get it.
Updated by Marko Lindqvist over 4 years ago
Marko Lindqvist wrote:
I think they should not get it.
I mean that I think that to be the current rule. I don't have strong opinion whether the rule makes sense or not.
Updated by fomalhaut pa over 4 years ago
They get bonus in ver2.5.9.
I reported this change because it's not written in the changelog.
I don't have strong opinion whether the rule makes sense or not.
I think so too. Either will do.
But help text also needs to be changed.
( - If the defender is a land unit, and is either fortified or inside a city, its strength is multiplied by 1.5.)
Updated by Marko Lindqvist over 4 years ago
Ok, it has changed between S2_5 and S2_6.
S2_5:
if ((pcity || fortified)
&& uclass_has_flag(utype_class(def_type), UCF_CAN_FORTIFY)) {
defensepower = (defensepower * 3) / 2;
}
S2_6:
if ((pcity || fortified)
&& uclass_has_flag(utype_class(def_type), UCF_CAN_FORTIFY)
&& !utype_has_flag(def_type, UTYF_CANT_FORTIFY)) {
defensepower = (defensepower * 3) / 2;
}
This came in as part of
commit 141ffe6785d2d9f4834d81e8a81c1ab38c7e9248
Author: Marko Lindqvist <cazfi74@gmail.com>
Date: Mon Aug 25 17:25:43 2014 +0000
Added "Cant_Fortify" unit type flag that overrides unit class flag "Can_Fortify"
for a single unit type. Automatically add it ruleset loading time to all units that
have "Settlers" flag.
See patch #5072
[[originally from svn r26042]]
Updated by Marko Lindqvist over 4 years ago
- Category changed from Rulesets to Documentation
fomalhaut pa wrote:
But help text also needs to be changed.
( - If the defender is a land unit, and is either fortified or inside a city, its strength is multiplied by 1.5.)
That help text needs rework in any case, since it has assumption that land units, and no other units, generally get the bonus. Even the old code made it to depend on unit class flag.
I vote for resolving this ticket by changing the helptext to match behavior.
Updated by Marko Lindqvist over 4 years ago
- Blocks Feature #698197: Documentation updates for S2_6 added
Updated by Marko Lindqvist about 3 years ago
- Subject changed from Worker, Settler, and Engineer in a city don't get defend bonus to Document that Worker, Settler, and Engineer in a city don't get defend bonus
Updated by Jacob Nevins about 3 years ago
- File m-30-26-help-fortify-bonus.patch m-30-26-help-fortify-bonus.patch added
- Status changed from New to Resolved
- Assignee set to Jacob Nevins
Updated by Jacob Nevins about 3 years ago
- Status changed from Resolved to Closed