Freeciv

Previous vague thoughts on the topic in feature #657143.

The code is being added for "/take" and not for "/delegate take" command. Why is that?

On lt.org you set delegations from the web site, so the freeciv server just needs logic to handle /take. I think there are a lot more fcdb script calls to be added like getting userlevel, so I will make a more extensive patch.

I think anything that changes the behavior of database.lua counts as datafile breaking, and I'm changing the return API for some things in there.

Zoltán Žarkov wrote:

On lt.org you set delegations from the web site, so the freeciv server just needs logic to handle /take. I think there are a lot more fcdb script calls to be added like getting userlevel, so I will make a more extensive patch.

Regardless where the delegation is first set, shouldn't this be "take" subcommand of "/delegate" and not completely separate command of "/take"? Even if it's ok for lt use-case, it doesn't seem like a right to do in our (upstream) code. There's a difference between "/take" and "/delegate take" and we don't want to lose ability to do "/take" semantics by making it behave like "/delegate take". Or have I misunderstood something completely?

• "delegate to" calls a lua function user_delegate_to to check permission if its a connection other than the assigned user or console.
• "take" and "observe" commands call lua user_take through is_allowed_to_take

script_fcdb_call("user_delegate_to", caller, dplayer, &ret) seems to be missing API_TYPE_STRING (password?) parameter defined for "user_delegate_to" in script_fcdb.c.

So database.lua does not implement user_delegate_to, but we rely on behavior being correct in complete lack of the function. I think I would prefer trivial user_delegate_to implementation to provide "no special permission", but that can wait to a new ticket (assuming current implementation does the right thing)

Have you successfully tested all of these cases:
- Permission is not granted when fcdb support is not built in at all (not built in by default in S3_0)
- Permission is not granted when "user_delegate_to" does not grant it
- Permission is granted when "user_delegate_to" grants it

I'm failing to get "user_delegate_to" to ever grant permissions, but there might be something wrong in my setup.

Just noticed that I had got:
1: in luascript_func_call_valist() [../../../../src/common/scriptcore/luascript_func.c::206]: assertion 'fcl' failed.

This is when I have fcdb support built in (so it really tries to call user_delegate_to when I request delegation) but not set player auth to use runtime.

You probably need to check srvarg.fcdb_enabled before calling script_fcdb_call()