Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #767129

Nation-specific starting units can start on non-native terrain, or on hut tile

Added by Jacob Nevins over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

While looking at init_new_game() for bug #767127, I noticed that standard player start units are placed with place_starting_unit(), which finds the nearest tile the unit type can exist on and gets rid of any hut there; but nation-specific start units don't benefit from this. Probably there's no good reason for the difference?


Related issues

Related to Freeciv - Bug #767127: Server can hang in find_dispersed_position() if scenario has invalid start positionResolved

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins over 2 years ago

  • Related to Bug #767127: Server can hang in find_dispersed_position() if scenario has invalid start position added

#2 Updated by Marko Lindqvist almost 2 years ago

Fix attached

Jacob Nevins wrote:

Probably there's no good reason for the difference?

Probably it was that way since create_starting_unit() took unit role while nation specific start units are already a specific unit type. Changed create_starting_unit() to work with either.

#3 Updated by Marko Lindqvist almost 2 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF