Feature #769078: Change call signature for luascript funcs to allow any return values - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Feature #769078

Change call signature for luascript funcs to allow any return values

Added by Zoltán Žarkov about 3 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

General

Sprint/Milestone:

3.0.0

Start date:

Due date:

% Done:

Estimated time:

Description

To allow for fcdb functions that return strings or other values, luascript calls should be able to take pointers for return values in the va_list.

0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch (38 KB) 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch	master	Zoltán Žarkov, 2018-08-12 09:49 PM
0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch (115 KB) 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch	master	Zoltán Žarkov, 2018-08-16 07:44 PM
0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch (119 KB) 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch	master	Zoltán Žarkov, 2018-08-16 09:38 PM
0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch (120 KB) 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch	master	Zoltán Žarkov, 2018-09-29 11:31 PM
0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch (113 KB) 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch	master	Zoltán Žarkov, 2018-09-30 06:05 PM
0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch (114 KB) 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch	master	Zoltán Žarkov, 2018-10-04 06:13 AM
0004-Change-call-signature-for-luascript-funcs-to-allow-a.patch (114 KB) 0004-Change-call-signature-for-luascript-funcs-to-allow-a.patch	S3_0	Zoltán Žarkov, 2018-10-06 01:48 AM

Related issues

History

#1 Updated by Zoltán Žarkov about 3 years ago

Blocks Feature #766520: Add fcdb hook for checking if player delegation is allowed added

#2 Updated by Zoltán Žarkov about 3 years ago

File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added

#3 Updated by Zoltán Žarkov about 3 years ago

File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added

I missed the signal emits before.

#4 Updated by Zoltán Žarkov about 3 years ago

File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added

With all files.

#5 Updated by Marko Lindqvist about 3 years ago

Sprint/Milestone changed from 3.0.0 to 3.1.0

Changing target version to 3.1. I don't think we want this big change to S3_0 any more, as a completely new feature (i.e. not an improvement to something that is already a 3.0 feature).

With a quick read found just two minor issues:

- luascript_func_call() function header uses lower case 'true' and 'false' where 'TRUE' and 'FALSE' should be used
- password is freed only if it's not NULL (good) AND not empty (not good)