HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Feature #769078
Change call signature for luascript funcs to allow any return values
0%
Description
To allow for fcdb functions that return strings or other values, luascript calls should be able to take pointers for return values in the va_list.
Related issues
History
#1
Updated by Zoltán Žarkov almost 4 years ago
- Blocks Feature #766520: Add fcdb hook for checking if player delegation is allowed added
#3
Updated by Zoltán Žarkov almost 4 years ago
- File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added
I missed the signal emits before.
#4
Updated by Zoltán Žarkov almost 4 years ago
- File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added
With all files.
#5
Updated by Marko Lindqvist over 3 years ago
- Sprint/Milestone changed from 3.0.0 to 3.1.0
Changing target version to 3.1. I don't think we want this big change to S3_0 any more, as a completely new feature (i.e. not an improvement to something that is already a 3.0 feature).
With a quick read found just two minor issues:
- luascript_func_call() function header uses lower case 'true' and 'false' where 'TRUE' and 'FALSE' should be used
- password is freed only if it's not NULL (good) AND not empty (not good)
#6
Updated by Zoltán Žarkov over 3 years ago
- File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added
- Password freed
- Header comments changed to TRUE and FALSE
#7
Updated by Marko Lindqvist over 3 years ago
- Category set to General
- Status changed from In Progress to Resolved
- Assignee changed from Zoltán Žarkov to Marko Lindqvist
#8
Updated by Zoltán Žarkov over 3 years ago
- File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added
I split out everything extraneous to the refactor.
#9
Updated by Zoltán Žarkov over 3 years ago
- File 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0001-Change-call-signature-for-luascript-funcs-to-allow-a.patch added
Tested in mysql and sqlite.
#10
Updated by Marko Lindqvist over 3 years ago
- Status changed from Resolved to Closed
#11
Updated by Marko Lindqvist over 3 years ago
- Status changed from Closed to In Progress
- Sprint/Milestone changed from 3.1.0 to 3.0.0
I think we need this for S3_0 after all, to support dependent features for longturn.org.
#12
Updated by Marko Lindqvist over 3 years ago
- Assignee changed from Marko Lindqvist to Zoltán Žarkov
#13
Updated by Zoltán Žarkov over 3 years ago
- File 0004-Change-call-signature-for-luascript-funcs-to-allow-a.patch 0004-Change-call-signature-for-luascript-funcs-to-allow-a.patch added
S3_0 rebase
#14
Updated by Marko Lindqvist over 3 years ago
- Status changed from In Progress to Resolved
- Assignee changed from Zoltán Žarkov to Marko Lindqvist
#15
Updated by Marko Lindqvist over 3 years ago
- Status changed from Resolved to Closed