Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #771536

City workers are auto-arranged when settler built, causing rapture to stall

Added by Zoltán Žarkov over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When a settler is built, auto_arrange_workers uses a CMA that ensures a food surplus, and sets some CMA factors to hardcoded values. This can be troublesome when building a settler when you are trying to rapture-grow a city. auto_arrange_workers does not attempt to keep a city celebrating, so rapture will often stall.

Proposed simple solution is to set cmp.require_happy to pcity->was_happy- presumably most players would mind much less if the server assumes they want to keep the city celebrating. A better solution might be to give players control over server-side CMA.

city_happy_before_act.patch (614 Bytes) city_happy_before_act.patch Anonymous, 2018-08-31 01:56 AM
city_happy_before_actV2.patch (1.24 KB) city_happy_before_actV2.patch Anonymous, 2018-08-31 03:51 PM
city_happy_before_actV3.patch (1.43 KB) city_happy_before_actV3.patch Anonymous, 2018-08-31 03:58 PM

Related issues

Has duplicate Freeciv - Feature #810338: Option to remove auto reassign worked tiles when city grow or shrinkNew

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Lexxie L over 2 years ago

I have experienced this and it's extremely annoying and illogical behaviour. I would mind much less if the server assumed I wanted to keep celebrating, so Zoltan is correct.

#2 Updated by Lexxie L over 2 years ago

At some point for a short while about a year and a half ago (ish?) this problem didn't happen, but then end-turn behaviour reverted to some prior sequence. That's a shame because there were some good things that got thrown out. Like this never happened, and you could build a Settler on the same turn you went to population 2.

#3 Updated by Anonymous over 2 years ago

Moved pcity->was_happy before auto_arrange_workers(pcity)

#4 Updated by Anonymous over 2 years ago

  • Sprint/Milestone changed from 3.0.0 to 2.6.1

#5 Updated by Zoltán Žarkov over 2 years ago

I think this is incorrect. pcity->was_happy should be set after city_build_stuff's city_refresh call. Otherwise, buying a temple won't have an effect the turn you buy it.

#6 Updated by Lexxie L over 2 years ago

yeah also I did some more tests, auto-rearrange is kinda nullifying what you pick for rapture... including specialists... you might do lots of tax collectors because you need gold to survive, and nope, it decides you wanted scientists instead... this is frustrating when altering tax rates and specialists to tune what you need for next turn and you don't get anything like what it said you were getting

#7 Updated by Anonymous over 2 years ago

This is new working tested patch.
Side effect is sometimes city will grow again and sometimes not, but will keep celebrating in both cases.

#8 Updated by Anonymous over 2 years ago

New patch without side effect mentioned earlier.

#9 Updated by Anonymous over 2 years ago

  • Status changed from Resolved to Closed

Commited here, because proposed patch from Task #771900 doesn't work.

#10 Updated by Zoltán Žarkov over 2 years ago

#771900 is the real fix for this, why did you submit that change?

#11 Updated by Anonymous over 2 years ago

I wrote it - doesn't work.

#12 Updated by Zoltán Žarkov over 2 years ago

Then comment in that ticket? Create a working patch for that ticket?

#13 Updated by Zoltán Žarkov over 2 years ago

Fixed in #771900.

#14 Updated by Zoltán Žarkov about 2 years ago

  • Has duplicate Feature #810338: Option to remove auto reassign worked tiles when city grow or shrink added

Also available in: Atom PDF