Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #772657

Delegation breaks because orig_username does not get saved in savegames

Added by Zoltán Žarkov almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I noticed that a player in fcweb game 0x10 was delegated when I had to restart server from a save and the player ended up unassigned when control was restored.

History

#4 Updated by Marko Lindqvist almost 3 years ago

I think all branches are affected, not only master?

#5 Updated by Zoltán Žarkov almost 3 years ago

This fix adds a field to track orig_username in savefile, breaking file compatibility for 2.6.

An alternative is to cancel active delegation when saving in 2.6, or accepting the breakage.

I will make an S3_0 patch as it is.

#6 Updated by Marko Lindqvist almost 3 years ago

Would there really be compatibility issues? If an older server loads savegame created by a newer server, it just ignores the field (as if it was not saved -> as if this change was not made). If a newer server loads savegame created by older server, it just gets default empty value (as secfile_lookup_str_default() is used), i.e. same value as it would get if it didn't even try to load it.

#8 Updated by Zoltán Žarkov almost 3 years ago

Above was S2_6

#9 Updated by Marko Lindqvist almost 3 years ago

  • Category set to Server
  • Sprint/Milestone set to 2.6.1

S3_0 & master should load orig_username also from savegame2.c saves, now that S2_6 might has put it in there.

#11 Updated by Zoltán Žarkov almost 3 years ago

Above applies cleanly to master as well.

#12 Updated by Marko Lindqvist almost 3 years ago

  • Status changed from New to Resolved
  • Assignee changed from Zoltán Žarkov to Marko Lindqvist

#13 Updated by Marko Lindqvist almost 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF