Bug #772657: Delegation breaks because orig_username does not get saved in savegames - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #772657

Delegation breaks because orig_username does not get saved in savegames

Added by Zoltán Žarkov almost 3 years ago. Updated almost 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Server

Sprint/Milestone:

2.6.1

Start date:

Due date:

% Done:

Estimated time:

Description

I noticed that a player in fcweb game 0x10 was delegated when I had to restart server from a save and the player ended up unassigned when control was restored.

0006-Save-orig_username-for-delegated-players-in-savegame.patch (1.6 KB) 0006-Save-orig_username-for-delegated-players-in-savegame.patch		Zoltán Žarkov, 2018-09-05 07:20 PM
0006-Save-orig_username-for-delegated-players-in-savegame.patch (1.6 KB) 0006-Save-orig_username-for-delegated-players-in-savegame.patch	master	Zoltán Žarkov, 2018-09-05 07:23 PM
0006-Save-orig_username-for-delegated-players-in-savegame.patch (1.6 KB) 0006-Save-orig_username-for-delegated-players-in-savegame.patch	master	Zoltán Žarkov, 2018-09-05 07:26 PM
0003-Save-orig_username-for-delegated-players-in-savegame.patch (1.6 KB) 0003-Save-orig_username-for-delegated-players-in-savegame.patch	S3_0	Zoltán Žarkov, 2018-09-29 07:38 AM
0002-Save-orig_username-for-delegated-players-in-savegame.patch (1.56 KB) 0002-Save-orig_username-for-delegated-players-in-savegame.patch	S2_6	Zoltán Žarkov, 2018-09-29 10:07 PM
0003-Save-orig_username-for-delegated-players-in-savegame.patch (2.41 KB) 0003-Save-orig_username-for-delegated-players-in-savegame.patch	S3_0	Zoltán Žarkov, 2018-09-30 06:03 AM

History

#1 Updated by Zoltán Žarkov almost 3 years ago

File 0006-Save-orig_username-for-delegated-players-in-savegame.patch 0006-Save-orig_username-for-delegated-players-in-savegame.patch added

#2 Updated by Zoltán Žarkov almost 3 years ago

File 0006-Save-orig_username-for-delegated-players-in-savegame.patch 0006-Save-orig_username-for-delegated-players-in-savegame.patch added

Corrected indentation

#3 Updated by Zoltán Žarkov almost 3 years ago

File 0006-Save-orig_username-for-delegated-players-in-savegame.patch 0006-Save-orig_username-for-delegated-players-in-savegame.patch added

Really corrected indentation

#4 Updated by Marko Lindqvist almost 3 years ago

I think all branches are affected, not only master?

#5 Updated by Zoltán Žarkov almost 3 years ago

File 0003-Save-orig_username-for-delegated-players-in-savegame.patch 0003-Save-orig_username-for-delegated-players-in-savegame.patch added

This fix adds a field to track orig_username in savefile, breaking file compatibility for 2.6.

An alternative is to cancel active delegation when saving in 2.6, or accepting the breakage.

I will make an S3_0 patch as it is.

#6 Updated by Marko Lindqvist almost 3 years ago

Would there really be compatibility issues? If an older server loads savegame created by a newer server, it just ignores the field (as if it was not saved -> as if this change was not made). If a newer server loads savegame created by older server, it just gets default empty value (as secfile_lookup_str_default() is used), i.e. same value as it would get if it didn't even try to load it.