Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #775057

Task #774803: Emscripten clients for web.

Function pointer casts not compatible with Emscripten

Added by Zoltán Žarkov about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Client
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

update_queue_add adds all kinds of callbacks as if they are all void (*uq_callback_t)(void *data). This is actually undefined behavior in C to call a void fn(void) this way. Native platforms don't complain, but wasm and asm.js care. See http://kripken.github.io/emscripten-site/docs/porting/guidelines/function_pointer_issues.html

History

#3 Updated by Marko Lindqvist about 3 years ago

  • Sprint/Milestone set to 2.6.1

Can you make versions for S3_0 and S2_6? I'm going to push master version already, though (assuming it passes ongoing build test)

#4 Updated by Marko Lindqvist about 3 years ago

When building stub-client:

../../../src/client/gui_cbsetter.c: In function ‘setup_gui_funcs’:
../../../src/client/gui_cbsetter.c:87:39: error: assignment to ‘void ()(void)’ from incompatible pointer type ‘void ()(void *)’ [-Werror=incompatible-pointer-types]
funcs->real_conn_list_dialog_update = gui_real_conn_list_dialog_update;

#8 Updated by Marko Lindqvist about 3 years ago

  • Category set to Client
  • Status changed from New to Resolved
  • Assignee changed from Zoltán Žarkov to Marko Lindqvist

#9 Updated by Marko Lindqvist about 3 years ago

S2_6 xaw-client build seems to fail. It's "unmaintained" in S2_6, but this is probably easy enough to fix (don't bother if it's not)

#10 Updated by Marko Lindqvist about 3 years ago

Oh, also sdl-client build fails (S2_6). It's supported client.

#12 Updated by Marko Lindqvist about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF