Bug #775057: Function pointer casts not compatible with Emscripten - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Bug #775057

Task #774803: Emscripten clients for web.

Function pointer casts not compatible with Emscripten

Added by Zoltán Žarkov almost 4 years ago. Updated almost 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Client

Sprint/Milestone:

2.6.1

Start date:

Due date:

% Done:

Estimated time:

Description

update_queue_add adds all kinds of callbacks as if they are all void (*uq_callback_t)(void *data). This is actually undefined behavior in C to call a void fn(void) this way. Native platforms don't complain, but wasm and asm.js care. See http://kripken.github.io/emscripten-site/docs/porting/guidelines/function_pointer_issues.html

0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch (43.2 KB) 0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch	master	Zoltán Žarkov, 2018-09-21 06:15 AM
0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch (43.2 KB) 0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch	master	Zoltán Žarkov, 2018-09-21 03:15 PM
0001-Change-all-callbacks-in-update_queue-to-void-cb-void.patch (45.5 KB) 0001-Change-all-callbacks-in-update_queue-to-void-cb-void.patch	S2_6	Zoltán Žarkov, 2018-09-29 01:47 AM
0002-Change-all-callbacks-in-update_queue-to-void-cb-void.patch (45.5 KB) 0002-Change-all-callbacks-in-update_queue-to-void-cb-void.patch	master	Zoltán Žarkov, 2018-09-29 01:47 AM
S3_0-Change-all-callbacks-in-update_queue-to-void-cb-void.patch (45.5 KB) S3_0-Change-all-callbacks-in-update_queue-to-void-cb-void.patch	S3_0	Zoltán Žarkov, 2018-09-29 01:50 AM
0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch (44.9 KB) 0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch	master	Zoltán Žarkov, 2018-09-29 01:56 AM
0001-Change-all-callbacks-in-update_queue-to-void-cb-void.patch (58.9 KB) 0001-Change-all-callbacks-in-update_queue-to-void-cb-void.patch		Zoltán Žarkov, 2018-09-29 09:57 PM

History

#1 Updated by Zoltán Žarkov almost 4 years ago

File 0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch 0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch added

#2 Updated by Zoltán Žarkov almost 4 years ago

File 0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch 0006-Change-all-callbacks-in-update_queue-to-void-cb-void.patch added

Changed all void* unused to void *unused

#3 Updated by Marko Lindqvist almost 4 years ago

Sprint/Milestone set to 2.6.1

Can you make versions for S3_0 and S2_6? I'm going to push master version already, though (assuming it passes ongoing build test)

#4 Updated by Marko Lindqvist almost 4 years ago

When building stub-client:

../../../src/client/gui_cbsetter.c: In function ‘setup_gui_funcs’:
../../../src/client/gui_cbsetter.c:87:39: error: assignment to ‘void ()(void)’ from incompatible pointer type ‘void ()(void *)’ [-Werror=incompatible-pointer-types]
funcs->real_conn_list_dialog_update = gui_real_conn_list_dialog_update;