Freeciv

The scripts need minor improvement: default.lua must not check extra type and might not return false, it's the bottom fallback; sandbox/script.lua should inform the player if the Hermit has left nothing.

Plans for future development:
1. Different hut behaviours for same units for different huts;
2. Some hints for AIs and autotasks about different bonuses value (even normal hut is better not to be enteted if bulbs are low and freetech fine is high);
3. Different bonuses removed by different actions, with a callback bool bonus_removed(unit, type, rmcause).

The idea is great, but I'm undecided if this should still go in to S3_0 or wait 3.1. Adding to S3_0 d3f blockers, so we need to at least to make a clear decision to postpone this to 3.1 before we can ignore it in S3_0 development.

At least, the type parameter for the callback should be added, it does not work without it. The frightening message also should be somehow configurable but it's of less importance. All the rest can be left for 3.1.

I think, for here we can keep the rule "that is enter removed what has "Hut" cause", just revert for both 3.0 and 2.6.1 what has commit:13f4a8097821152907155bc0b560e25fe1e9a578 done to unittools.h (this does not workas expected and may work as not wanted, it's a bug). Then, for 3.0 add the second callback parameter and maybe char * frighten_message; to struct extra and corresponding optional line frighten_message = "Your unit is so fearful, the extra runs away!" to extra description format, since defaul one doesn't suit for Hermit's Nest. (with optional %s for unit type); in other aspects, frighten behaviour seems not needing unhardcoding. I can prepare the 3.0 patch in a week. All other ideas are to be planned more careful and left to 3.1 (wanna add appearing and quickly disappearing UFOs to sandbox which are "entered" by aircrafts).

Alexandro Ignatiev wrote:

I think, for here we can keep the rule "that is enter removed what has "Hut" cause", just revert for both 3.0 and 2.6.1 what has commit:13f4a8097821152907155bc0b560e25fe1e9a578 done to unittools.h

Yes, that commit has been ill advised. Reverting it would be the first step, and the only one that affects also S2_6 -> please open a new ticket about that.

Since the huts detection is reverted for 3.0 by #782719, two lines shold be excluded from the patch as already changed.

Also, it redefines a callback with one more parameter. This is said to not be done, but I propose to lax a bit the rules and allow to add parameters for a good reason if the callback which does not check it will work as before. Lua functions are not really called with prototypes, they just get from the stack as many arguments as they want and assume nil's for what they have not found; there is a way to check what's there in the actual Lua stack, but I can't pretend a sane mean to use it in callbacks.