Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #794114

[master] SDL2 client incompatible with civ2civ3

Added by Louis Moureaux almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Category:
gui-sdl2
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The SDL2 client isn't compatible with civ2civ3 in master because it doesn't have an option to set the target government. civ2civ3 appears to prevent revolution without a target gov:

You can't revolt without a target government

I suggest that either this limitation is removed from civ2civ3, or the SDL2 client is updated.

I may have time to look into updating the client, but would benefit from some guidance.

History

#1 Updated by Marko Lindqvist over 2 years ago

Aren't earlier branches affected? Why not?

#2 Updated by Louis Moureaux over 2 years ago

I set 3.1.0 because that's what I was testing with. I think this issue was introduced in 2016 in commit c97a0f3f. I haven't checked if it's present in S2_6.

#3 Updated by Marko Lindqvist over 2 years ago

  • Status changed from New to In Progress
  • Sprint/Milestone changed from 3.1.0 to 2.6.1

This turns out rather simple to fix. Just popup (existing) government dialog instead of revolution dialog. Revolution dialog code can be removed completely. Patches to follow.

#5 Updated by Marko Lindqvist over 2 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF