Freeciv

In freeciv git master 35dabcd, I won by spaceship, then saved the game (in the attached game18-turn404-end.sav.xz). Now I can't load the game because the server gets stuck in an infinite loop. The automatic save (freeciv-T0404-Y01978-final.sav.xz) has the same problem as the attached one.

When I load the save in freeciv-gtk3.22 and click the Start button, I get an infinite stream of chat messages. Most say, "Warning: Famine feared in Eskişehir.", but there are also messages about native unrest, sea raiders, and disasters (like fire and flood). The client is stuck on the loading screen (with the list of players) and never enters the actual game. I need to send SIGTERM to freeciv-server.

The save (viewed with xzless) has phase=1 in the [game] section. Most other saves have phase=0. This seems to set game.info.phase = 1 in the code. server/srv_main.c srv_running() has a loop

  while (S_S_RUNNING == server_state()) {
    ...
    begin_turn(is_new_turn);
    ...
    for (; game.info.phase < game.server.num_phases; game.info.phase++) {
      ...
    }
    ...
    end_turn();
  }

GDB shows game.info.phase is 1, and game.server.num_phases is also 1, so the inner for loop never runs; but the inner loop seems to contain the logic for talking to clients. The server seems to ignore the clients and have the outer while loop be looping forever. I added a breakpoint at begin_turn, restarted the server, and set game.info.phase = 0 in GDB; this fixed my problem as the actual game appeared in my client.

Guess that Freeciv is missing logic to load saves when game.info.phase == game.server.num_phases