Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #820731

Scorelog module does not respect ruleset set game start year

Added by Marko Lindqvist about 2 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Server
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Jacob Nevins in Bug #767130:
"Noticed in passing: log_civ_score_now() tests game.info.year against the hardcoded GAME_START_YEAR, not the ruleset value. That should probably be replaced with something more robust."


Related issues

Related to Freeciv - Bug #767130: Scenario start year ignored unless scenario contains saved playersClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Related to Freeciv - Feature #923660: Rename GAME_START_YEAR as GAME_DEFAULT_START_YEARClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins almost 2 years ago

  • Related to Bug #767130: Scenario start year ignored unless scenario contains saved players added

#2 Updated by Marko Lindqvist 4 months ago

  • Sprint/Milestone set to 2.6.4

#3 Updated by Marko Lindqvist 3 months ago

  • Related to Feature #923660: Rename GAME_START_YEAR as GAME_DEFAULT_START_YEAR added

#4 Updated by Marko Lindqvist 3 months ago

game.server.start_year is correctly set up already when the scorelog is first called, so fixing this should be as trivial as attached patches.

#5 Updated by Marko Lindqvist 2 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF