HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Bug #823695
HutTech unit flag
Start date:
Due date:
% Done:
0%
Estimated time:
Description
common/unittype.h
, all current branches with just different numbers:
/* can be found in hut, global tech required */
#define SPECENUM_VALUE80 L_HUT_TECH
#define SPECENUM_VALUE80NAME N_("?unitflag:HutTech")
In fact, the unit is given in
default.lua
by local owner = unit.owner
local type = find.role_unit_type('HutTech', owner)
while the method is
Unit_Type *api_find_role_unit_type(lua_State *L, const char *role_name,
Player *pplayer)
{// ...
if (pplayer) {
return best_role_unit_for_player(pplayer, role_or_flag);
}//...
}
that in fact requires that the player, not anybody, can build the unit. Either the comment should be corrected or we should give a unit using somehow
find_a_unit_type(role, role_tech)
.
History
#1
Updated by Marko Lindqvist about 1 year ago
- Category set to General
- Status changed from New to In Progress
Ruleset documentation say just that tech is required, not promising that global tech would be enough. So the comment seems to be what is in error here.
#2
Updated by Marko Lindqvist about 1 year ago
- File 0011-Correct-code-comment-about-HutTech-unit-role.patch 0011-Correct-code-comment-about-HutTech-unit-role.patch added
- File 0004-Correct-code-comment-about-HutTech-unit-role.patch 0004-Correct-code-comment-about-HutTech-unit-role.patch added
- File 0002-Correct-code-comment-about-HutTech-unit-role.patch 0002-Correct-code-comment-about-HutTech-unit-role.patch added
- File 0002-Correct-code-comment-about-HutTech-unit-role.patch 0002-Correct-code-comment-about-HutTech-unit-role.patch added
- Status changed from In Progress to Resolved
- Sprint/Milestone changed from 2.6.1 to 2.5.12
#3
Updated by Marko Lindqvist about 1 year ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist