HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Bug #824278
PF: Failing fuel map assert 'NS_NEW == node1->status'
0%
Description
I've got assert 'NS_NEW node1->status' at path_finding.c:2824 failing in autogame with "Coast" unit. I think the assert is just part of copypaste code from handling of regular pathfinding maps, and it ignores the fact that in case of fuel maps even NS_PROCESSED and NS_WAITING can get past this check at line 2680 if node1->moves_left_req > 0:
/* Non-full fuel tiles can be updated even after being processed. /
if ((NS_PROCESSED node1->status || NS_WAITING node1->status)
&& 0 node1->moves_left_req) {
/ This gives 15% speedup. */
continue;
}
History
#1
Updated by Marko Lindqvist almost 2 years ago
- File 0055-PF-Relax-overzealous-assert.patch 0055-PF-Relax-overzealous-assert.patch added
- Status changed from New to Resolved
- Sprint/Milestone set to 2.6.1
#2
Updated by Marko Lindqvist almost 2 years ago
- Fixed another assert of the same vein
#3
Updated by Marko Lindqvist almost 2 years ago
- Status changed from Resolved to New
More serious than fc_assert() warning is the fact that the case can actually lead to infinite looping.
#4
Updated by Marko Lindqvist almost 2 years ago
- File 0045-PF-Fix-handling-of-NS_PROCESSED-in-fuel-map-iteratio.patch 0045-PF-Fix-handling-of-NS_PROCESSED-in-fuel-map-iteratio.patch added
- Status changed from New to Resolved
Fix that has gone through some autogame testing already.
#5
Updated by Marko Lindqvist almost 2 years ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist