Project

General

Profile

Bug #833269

msys2: Windows builds cannot access HTTPS

Added by Zoltán Žarkov 11 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
Client
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

A user reported that the current 2.6 gtk3 windows build is unable to fetch a modpack from an https url.

0016-msys2-Fix-https-usage.patch (1.51 KB) 0016-msys2-Fix-https-usage.patch Marko Lindqvist, 2019-12-27 05:54 AM

Related issues

Related to Freeciv - Task #656477: Update modpack servers not to point to svn.gna.orgIn Progress

Related to Freeciv - Bug #853960: msys1: Windows builds cannot access HTTPSClosed

History

#1 Updated by Jacob Nevins 7 months ago

I'm not massively surprised. Some previous thoughts in gna task #7989 .

#2 Updated by Jacob Nevins 7 months ago

  • Target version changed from 2.6.1 to 2.6.2

#3 Updated by Marko Lindqvist 7 months ago

See also Task #656477

#4 Updated by Marko Lindqvist 7 months ago

  • Related to Task #656477: Update modpack servers not to point to svn.gna.org added

#5 Updated by Marko Lindqvist 7 months ago

I tested with S3_0 msys2 (environment 191012, i.e., quite recent). Freeciv-mp-gtk3 installed by the installer does not work with https. However, running freeciv-mp-gtk3 from the build directory, inside full msys2 environment, does work. In this case, at least, the problem seems to be that certificates are not installed by the installer. In older environments certs can of course be also outdated.

#6 Updated by Marko Lindqvist 7 months ago

Attached patch for S3_0/master msys2 has two parts; install certs in installer Makefile, and take the installed certs to use by utility/ code change.
Will continue with S2_6 changes, but going to push S3_0/master part in ~36h.

#7 Updated by Marko Lindqvist 7 months ago

Marko Lindqvist wrote:

take the installed certs to use by utility/ code change.

As this sets installer specific certs path to use in Windows builds, presumably non-installer builds break (as far as they ever worked). Still, installer is the most important use-case by far, so going forward with this and trying to address other use-cases in future tickets.

#8 Updated by Marko Lindqvist 7 months ago

Marko Lindqvist wrote:

Will continue with S2_6 changes, but going to push S3_0/master part in ~36h.

I will split msys1 changes to a new patch, so the existing msys2 patch (so far marked S3_0/master only) can go to S2_6 too.

#9 Updated by Marko Lindqvist 7 months ago

  • Subject changed from Windows builds cannot access HTTPS to msys2: Windows builds cannot access HTTPS

Marko Lindqvist wrote:

I will split msys1 changes to a new patch

-> Bug #853960

#10 Updated by Marko Lindqvist 7 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

#11 Updated by Jacob Nevins 6 months ago

  • Related to Bug #853960: msys1: Windows builds cannot access HTTPS added

Also available in: Atom PDF