Project

General

Profile

Bug #851568

Gtk3+: handle "close" signal in more GtkDialogs?

Added by Jacob Nevins 7 months ago. Updated 7 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
gui-gtk-3
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Bug #689225 was caused by not handling the 'close' signal as well as the 'response' signal in a GtkDialog. This led to our cancel handlers not being run.

That bug fixed it for input_dialog, but on a quick look we have are lots of other GtkDialogs that handle "response" but not "close".

This bug is to deal with the rest -- either add "close" handlers, or figure out what we should do to funnel 'Esc' to the "response" handler, or something.


Related issues

Related to Freeciv - Bug #689225: Settlers refuse to settleClosed

History

#1 Updated by Jacob Nevins 7 months ago

  • Related to Bug #689225: Settlers refuse to settle added

#2 Updated by Jacob Nevins 7 months ago

In bug #689225, this appeared to be correlated with Gtk3 version. It looks like the behaviour changed sometime between 3.10.8 and 3.22.11, which is a big search space.

The only relevant-looking thing I've found is this in the 3.16 changelog : "The lookup order for actions that are activated via keyboard accelerators has been changed to start at the currently focused widget." (bz 740682 ?)

Gtk2 has the same 'close' signal, described the same way. Is it just luck that we aren't seeing the same symptom with Gtk2?

Also available in: Atom PDF