Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. "Read more...":https://support.plan.io/news/187
Actions
Send by e-mail Copy link

Bug #851728

closed

advance_name_for_player() & advance_name_by_player() return address of local variable

Added by Marko Lindqvist over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marko Lindqvist
Category:
General
Sprint/Milestone:
2.5.12
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Reported by gcc-10 from S2_5. Other branches presumably affected. advance_name_for_player() and advance_name_by_player() may return address of local 'char buffer[]'.

Files

Download all files
0001-Refactor-code-to-avoid-gcc-10-warning.patch (2.51 KB) 0001-Refactor-code-to-avoid-gcc-10-warning.patch master, S3_0, S2_6 Marko Lindqvist, 2019-12-11 11:39 PM
0001-Refactor-code-to-avoid-gcc-10-warning.patch (2.69 KB) 0001-Refactor-code-to-avoid-gcc-10-warning.patch S2_5 Marko Lindqvist, 2019-12-11 11:39 PM
Actions
Copy link
 #1

Updated by Marko Lindqvist over 3 years ago

  • Status changed from In Progress to New
  • Sprint/Milestone deleted (2.5.12)

I think (development version of) compiler misdiagnoses the code.

Actions
Copy link
 #2

Updated by Marko Lindqvist over 3 years ago

  • Sprint/Milestone set to 2.6.2
Actions
Copy link
 #3

Updated by Marko Lindqvist over 3 years ago

After much playing around with the code and the compiler I'm more convinced that it's the compiler that is acting up. Still, refactoring the code to something I consider also cleaner makes the warning to go away, so it shouldn't hurt.

Actions
Copy link
 #4

Updated by Marko Lindqvist over 3 years ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist
Actions
Send by e-mail Copy link

Also available in: Atom PDF