Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Feature #852929

Enable -Wimplicit-fallthrough

Added by Marko Lindqvist over 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
Bootstrap
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Quick testing with -Wimplicit-fallthrough reveals several bugs. It would be good to have it always enabled in --enable-debug build.


Related issues

Related to Freeciv - Feature #676276: Enable -WextraIn Progress

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Related to Freeciv - Feature #852923: fc__fallthroughClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Related to Freeciv - Bug #852927: Missing breaks in universal_value_from_str()Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Marko Lindqvist over 2 years ago

  • Status changed from New to In Progress
  • Sprint/Milestone set to 2.6.2

#2 Updated by Marko Lindqvist over 2 years ago

#3 Updated by Marko Lindqvist over 2 years ago

#4 Updated by Marko Lindqvist over 2 years ago

  • Related to Bug #852927: Missing breaks in universal_value_from_str() added

#5 Updated by Jacob Nevins over 2 years ago

Lots of recent improvements here, but are we ready to enable the warning on S2_6?

#6 Updated by Marko Lindqvist over 2 years ago

  • Sprint/Milestone changed from 2.6.2 to 2.6.3

#7 Updated by Marko Lindqvist over 2 years ago

  • Sprint/Milestone deleted (2.6.3)

Updated SDL2 system headers cause implicit fallthrough warning. We can't enable the warnings.

#8 Updated by Louis Moureaux over 2 years ago

With -isystem instead of -I it should be fine.

#9 Updated by Marko Lindqvist over 2 years ago

Louis Moureaux wrote:

With -isystem instead of -I it should be fine.

That's something that comes from the sdl2.pc, i.e., is not in our control either.

#10 Updated by Marko Lindqvist 11 months ago

Let's add it for --enable-debug=checks. That's allowed to fail under some configurations, i.e., one simply should not use it when compiling incompatible sdl2-client with incompatible headers.

#11 Updated by Marko Lindqvist 10 months ago

  • Sprint/Milestone set to 3.0.0

#12 Updated by Marko Lindqvist 10 months ago

I'd prefer to push this even to S2_6, simply to make testing the branch against fallthrough errors easier (no need to apply patch locally). This does not affect normal builds (including standard --enable-debug), but only special --enable-debug=checks which is already considered not to be that stable set.

#13 Updated by Marko Lindqvist 10 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF