HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Bug #852938
closed
assertion 'gold_upkeep > 0' failed
0%
Description
Augmented2 (old version) autogame in S2_6:
0: in sell_random_unit() [../../src/server/cityturn.c::2538]: assertion 'gold_upkeep > 0' failed.
Files
Updated by Marko Lindqvist over 3 years ago
I think sell_random_unit() could fail at least in case of recursive transports where the middle transport is not part of punitlist (so recursion does not go through it). This is possible if its upkeep is 0, or it's owned by an ally.
Updated by Marko Lindqvist over 3 years ago
Marko Lindqvist wrote:
I think sell_random_unit() could fail at least in case of recursive transports where the middle transport is not part of punitlist (so recursion does not go through it).
...in which case units from punitlist might get recursively wiped without being removed from the punitlist. It's possible that it then later tries to sell such already wiped unit -> potential for a real crash (not limited to assert failure).
Updated by Marko Lindqvist over 3 years ago
- Category set to Server
- Status changed from New to In Progress
Reserving this ticket for fixing the identified crash.
The original assert is reproducible but autogame takes hours to run to that point. If it turns to be different issue, will open a new ticket for it.
Updated by Marko Lindqvist over 3 years ago
- File 0023-Fix-sell_random_unit-crash-with-recursive-transports.patch 0023-Fix-sell_random_unit-crash-with-recursive-transports.patch added
- File 0008-Fix-sell_random_unit-crash-with-recursive-transports.patch 0008-Fix-sell_random_unit-crash-with-recursive-transports.patch added
- Status changed from In Progress to Resolved
Updated by Marko Lindqvist over 3 years ago
- File 0023-Fix-sell_random_unit-crash-with-recursive-transports.patch 0023-Fix-sell_random_unit-crash-with-recursive-transports.patch added
- File 0008-Fix-sell_random_unit-crash-with-recursive-transports.patch 0008-Fix-sell_random_unit-crash-with-recursive-transports.patch added
Improved comments
Updated by Marko Lindqvist over 3 years ago
Marko Lindqvist wrote:
The original assert is reproducible but autogame takes hours to run to that point. If it turns to be different issue, will open a new ticket for it.
-> Bug #853107
Updated by Marko Lindqvist over 3 years ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist
.