Project

General

Profile

Bug #852938

assertion 'gold_upkeep > 0' failed

Added by Marko Lindqvist 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
Server
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Augmented2 (old version) autogame in S2_6:

0: in sell_random_unit() [../../src/server/cityturn.c::2538]: assertion 'gold_upkeep > 0' failed.

History

#1 Updated by Marko Lindqvist 7 months ago

I think sell_random_unit() could fail at least in case of recursive transports where the middle transport is not part of punitlist (so recursion does not go through it). This is possible if its upkeep is 0, or it's owned by an ally.

#2 Updated by Marko Lindqvist 7 months ago

Marko Lindqvist wrote:

I think sell_random_unit() could fail at least in case of recursive transports where the middle transport is not part of punitlist (so recursion does not go through it).

...in which case units from punitlist might get recursively wiped without being removed from the punitlist. It's possible that it then later tries to sell such already wiped unit -> potential for a real crash (not limited to assert failure).

#3 Updated by Marko Lindqvist 7 months ago

  • Category set to Server
  • Status changed from New to In Progress

Reserving this ticket for fixing the identified crash.

The original assert is reproducible but autogame takes hours to run to that point. If it turns to be different issue, will open a new ticket for it.

#6 Updated by Marko Lindqvist 7 months ago

Marko Lindqvist wrote:

The original assert is reproducible but autogame takes hours to run to that point. If it turns to be different issue, will open a new ticket for it.

-> Bug #853107

#7 Updated by Marko Lindqvist 7 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF