Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #853128

Unit select dialog groups units building mine extras under heading "Plant"

Added by Jacob Nevins almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Low
Category:
General
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Seen with 2.6.1, gui-gtk-3.22:

In the unit selection dialog, units which are building Mine extras are grouped under the heading "Plant"; see screenshot. This was a bit surprising; I was expecting "Mine".

This is due to usdlg_tab_append_activity() calling get_activity_text(), which describes ACTIVITY_MINE as "Plant". This was changed in gna patch #4382, with commit comment 'List terrain changing ACTIVITY_MINE as "Plant"'. But in this case it refers to units that aren't changing terrain.

I guess that all units either building mine extras or changing terrain would be lumped into the same category, and as long as that's the case the name will stay a bit awkward. I haven't thought about what the situation is on later branches.

plant.png (39 KB) plant.png 2.6.1, gui-gtk-3.22, civ1 ruleset Jacob Nevins, 2019-12-18 11:14 PM
0038-get_activity_text-Return-Mine-as-name-of-ACTIVITY_MI.patch (917 Bytes) 0038-get_activity_text-Return-Mine-as-name-of-ACTIVITY_MI.patch master Marko Lindqvist, 2020-05-02 07:26 PM
0014-get_activity_text-Return-Mine-as-name-of-ACTIVITY_MI.patch (1.02 KB) 0014-get_activity_text-Return-Mine-as-name-of-ACTIVITY_MI.patch S3_0, S2_6 Marko Lindqvist, 2020-05-02 07:26 PM
250

History

#1 Updated by Marko Lindqvist almost 2 years ago

Jacob Nevins wrote:

Seen with 2.6.1

I haven't thought about what the situation is on later branches.

There would be no relevant change in S3_0. Master has separate Cultivate/Plant activities, so at least there Mine activity should be changed back to unconditionally use name "Mine" (but that change has not yet been made, and will probably happen under another ticket).

#2 Updated by Marko Lindqvist over 1 year ago

Marko Lindqvist wrote:

Jacob Nevins wrote:

Seen with 2.6.1

I haven't thought about what the situation is on later branches.

There would be no relevant change in S3_0. Master has separate Cultivate/Plant activities, so at least there Mine activity should be changed back to unconditionally use name "Mine" (but that change has not yet been made, and will probably happen under another ticket).

Attached patches do the change. For master that's certainly right way to go as forward development with separate ACTIVITY_PLANT in place. For older branches this reverts the "untargeted Mine is called Plant" change, and as such could be disputable. I think the right thing to do is to do this revert - to wait for 3.1 for the proper ACTIVITY_PLANT for the "Plant" stuff.

#3 Updated by Marko Lindqvist over 1 year ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF