Bug #853140
qtg_gui_clear_theme() doesn't fallback all the way to FC_QT_DEFAULT_THEME_NAME
Start date:
Due date:
% Done:
0%
Estimated time:
Description
qtg_gui_clear_theme() should go to a theme that is guaranteed (or as close to that as possible) to exist. Currently it uses default theme name from settings, but that theme might just have been available in some user data directory in the past. Instead FC_QT_DEFAULT_THEME_NAME, that is at least known to be provided by freeciv installation, should be used.
Related issues
History
#1
Updated by Marko Lindqvist 7 months ago
- Related to Bug #853130: Qt client configuration can end up with illegal theme "Freeciv", leading to display problems added
#2
Updated by Marko Lindqvist 7 months ago
Also qtg_gui_load_theme() assumes such a behavior from qtg_gui_clear_theme() where it tries to avoid infinite recursion by checking against FC_QT_DEFAULT_THEME_NAME, not default theme name from settings.
#3
Updated by Marko Lindqvist 7 months ago
- File 0011-Qt-Use-FC_QT_DEFAULT_THEME_NAME-theme-when-clearing-.patch 0011-Qt-Use-FC_QT_DEFAULT_THEME_NAME-theme-when-clearing-.patch added
- Status changed from In Progress to Resolved
#4
Updated by Marko Lindqvist 7 months ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist