Project

General

Profile

Feature #853406

enable sys tolua cmd

Added by Luc Schrijvers 7 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Normal
Category:
Bootstrap
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When trying to build a local checkout (S2_6) I'm trying to pass the --enable-sys-lua-cmd=true but Freeciv still builds the included cmd tolua, this is on 64-bit Haiku


Related issues

Related to Freeciv - Feature #652961: Build tolua cmd only if sys tolua not usedClosed

History

#1 Updated by Luc Schrijvers 7 months ago

Building the library is OK and doesn't produce errors, building the cmd works also but I get a lot of undefined references (lua_rotate, lua_callk, lua_tonumberx, lua_setglobal ...)

#2 Updated by Marko Lindqvist 7 months ago

  • Category set to Bootstrap
  • Status changed from New to In Progress
  • Target version set to 2.6.2

Based on irc discussion we should prevent building of tolua(.exe) when --enable-sys-tolua-cmd is used, and thus tolua(.exe) is not needed.

#3 Updated by Marko Lindqvist 7 months ago

  • Tracker changed from Task to Feature

Master already seems to attempt that. But the implementation there is different, and I think just plain buggy, compared to the patch I'm preparing for S2_6/S3_0.

#4 Updated by Marko Lindqvist 7 months ago

Patch for S2_6/S3_0.
Master is probably fine, after all. In any case it would require a new ticket if broken.

#5 Updated by Marko Lindqvist 7 months ago

  • Related to Feature #652961: Build tolua cmd only if sys tolua not used added

#6 Updated by Marko Lindqvist 7 months ago

Marko Lindqvist wrote:

Master already seems to attempt that.

Since Feature #652961

#7 Updated by Marko Lindqvist 7 months ago

Minor cleanup to master inspired by the implementation of older branches, regardless.

#8 Updated by Marko Lindqvist 7 months ago

  • Status changed from Resolved to Closed
  • Assignee set to Marko Lindqvist

Also available in: Atom PDF