Feature #853406: enable sys tolua cmd - Freeciv - HostedRedmine by Planio

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Send by e-mail

Feature #853406

enable sys tolua cmd

Added by Luc Schrijvers about 1 year ago. Updated about 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Marko Lindqvist

Category:

Bootstrap

Sprint/Milestone:

2.6.2

Start date:

Due date:

% Done:

Estimated time:

Description

When trying to build a local checkout (S2_6) I'm trying to pass the --enable-sys-lua-cmd=true but Freeciv still builds the included cmd tolua, this is on 64-bit Haiku

0019-Do-not-build-tolua-command-at-all-when-enable-sys-to.patch (1.86 KB) 0019-Do-not-build-tolua-command-at-all-when-enable-sys-to.patch		Marko Lindqvist, 2019-12-21 09:25 AM
0020-Cleanup-SYS_TOLUA_CMD-handling-in-tolua-5.2-Makefile.patch (812 Bytes) 0020-Cleanup-SYS_TOLUA_CMD-handling-in-tolua-5.2-Makefile.patch	master	Marko Lindqvist, 2019-12-21 09:34 AM

Related issues

History

#1 Updated by Luc Schrijvers about 1 year ago

Building the library is OK and doesn't produce errors, building the cmd works also but I get a lot of undefined references (lua_rotate, lua_callk, lua_tonumberx, lua_setglobal ...)

#2 Updated by Marko Lindqvist about 1 year ago

Category set to Bootstrap
Status changed from New to In Progress
Sprint/Milestone set to 2.6.2

Based on irc discussion we should prevent building of tolua(.exe) when --enable-sys-tolua-cmd is used, and thus tolua(.exe) is not needed.

#3 Updated by Marko Lindqvist about 1 year ago

Tracker changed from Task to Feature

Master already seems to attempt that. But the implementation there is different, and I think just plain buggy, compared to the patch I'm preparing for S2_6/S3_0.