Bug #853520
-Wimplicit-fallthrough in research_total_bulbs_required()
Start date:
Due date:
% Done:
0%
Estimated time:
Description
When -Wimplicit-fallthrough (missing 'break' warnings) are enabled, one warning is given from research_total_bulbs_required(), research.c:898.
In this case it's not obvious by quick glance if there should be a break or is fallthrough right thing to do (fc__fallthrough from Feature #852923)
History
#1
Updated by Marko Lindqvist 7 months ago
- File 0025-Explicitly-mark-fc__fallthrough-in-research_total_bu.patch 0025-Explicitly-mark-fc__fallthrough-in-research_total_bu.patch added
- Status changed from New to Resolved
All callers seem to always pass presearch, so the execution should never reach that point in practice. Attached patch adds an assert() and makes existing fallthrough explicit with fc__fallthrough (to fallback to setting cost by other methods)
#2
Updated by Marko Lindqvist 6 months ago
- Status changed from Resolved to Closed
- Assignee set to Marko Lindqvist