Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #854306

Traderoute_Pct effect confuses city report popup trade breakdown

Added by Jacob Nevins almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Client
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The city report popup for trade displays a confused and incorrect sum in cities with trade routes if any Traderoute_Pct effect is in play. The final trade amount reported is correct, as is the contribution from each trade route, but there's an additional spurious "(unknown)" term.

This is because the code to keep track of the running total to sanity check the calculation was not updated.

I'm looking at a rework of these sums to reduce the redundant code, but for now here's the obvious fix.

traderoute_pct_citydlg.png (16.2 KB) traderoute_pct_citydlg.png S2_6 civ1 with "Traderoute_Pct" set to -50 globally Jacob Nevins, 2019-12-30 10:35 AM
26-citydlg-traderoute-pct-confusion.patch (1.32 KB) 26-citydlg-traderoute-pct-confusion.patch Jacob Nevins, 2019-12-30 01:08 PM
250

History

#1 Updated by Jacob Nevins almost 2 years ago

This bug is specific to S2_6; code has been reworked on later branches and doesn't have the bug.

Looking on modpack server, 3.0 variant2 has a Traderoute_Pct bonus for Cheating AI, but only observers could notice the bug there.

#2 Updated by Jacob Nevins almost 2 years ago

#3 Updated by Jacob Nevins almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF