Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #854477

SDL2: non-left mouse buttons (and maybe finger events?) don't work in various places

Added by Jacob Nevins over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
gui-sdl2
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

While auditing usage of SDL_BUTTON_LEFT for hrm #854476, I found various related mistakes:
  • Over-enthusiastic use of PRESSED_EVENT() in hrm feature #831742
    • Right-click on cities button doesn't bring up "find city"
    • Right-click on players button doesn't bring up menu of living players
    • (Additionally, after my previous patch for #854476, Ctrl-F starts doing the wrong thing.)
  • More testing for SDL_BUTTON_LEFT without checking it's a mouse event. This might cause finger events on the following UI elements to do the wrong thing (haven't tested):
    • Flag icons in players report and menu (should start a meeting)
    • Unit info (bottom right of main view) (should move to next unit)
    • Various bits of worklist UI

The SDL client makes some similar mistakes, but as far as I can tell it's not causing any bugs there.

m-sdl2-other-buttons.patch (10.6 KB) m-sdl2-other-buttons.patch master Jacob Nevins, 2020-01-01 06:27 PM
30-sdl2-other-buttons.patch (11.1 KB) 30-sdl2-other-buttons.patch S3_0 Jacob Nevins, 2020-01-01 06:27 PM
26-sdl2-other-buttons.patch (19.3 KB) 26-sdl2-other-buttons.patch S2_6 Jacob Nevins, 2020-01-01 06:27 PM

Related issues

Related to Freeciv - Bug #854476: SDL2: keyboard shortcuts broken in many places (e.g. Esc to bring up options dialog)Closed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins over 1 year ago

  • Related to Bug #854476: SDL2: keyboard shortcuts broken in many places (e.g. Esc to bring up options dialog) added

#3 Updated by Jacob Nevins over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF