Project

General

Profile

Feature #854615

Comment purpose of fc_config.h in binary distributions

Added by Jacob Nevins 6 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Bootstrap
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

We ship fc_config.h in the Windows releases. (gna patch #6544)
It could do with a comment explaining what it is for, in that context, in case someone thinks it is a configuration file that they can usefully edit.

(AH_TOP macro came in in 2000 , in Autoconf 2.50 or earlier. Our minimum version is 2.61.)

m-fc-config-comment.patch (1.54 KB) m-fc-config-comment.patch master Jacob Nevins, 2020-01-02 05:37 PM
30-26-fc-config-comment.patch (1.02 KB) 30-26-fc-config-comment.patch S3_0, S2_6 Jacob Nevins, 2020-01-02 05:37 PM
m-fc-config-comment-bis.patch (2.31 KB) m-fc-config-comment-bis.patch master: address #2 Jacob Nevins, 2020-01-02 06:00 PM

History

#1 Updated by Jacob Nevins 6 months ago

(Also added to Meson-generated file for consistency, even though Meson build doesn't obviously install fc_config.h yet.)

#2 Updated by Marko Lindqvist 6 months ago

Jacob Nevins wrote:

(Also added to Meson-generated file for consistency, even though Meson build doesn't obviously install fc_config.h yet.)

Should it also be added to freeciv_config.h of meson builds? Autotools version installs only fc_config.h as it's strictly a superset of freeciv_config.h (there's nothing in freeciv_config.h that's not in fc_config.h). Meson version of fc_config.h does not contain freeciv_config.h stuff, but #includes it. So presumably we are going to install both fc_config.h and freeciv_config.h of meson based builds in the future.

#4 Updated by Jacob Nevins 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF