Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...

Bug #855938

"Multicultural" achievement described wrongly in rulesets

Added by Jacob Nevins about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rulesets
Sprint/Milestone:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

I introduced an error in one of my "string tweaks" (#689474), in 2017.

I changed the text for the "Multicultural" achievement in various rulesets from
  • "In your nation there are citizens of 2 different nationalities!"
to
  • "One of your cities has 2 different nationalities!"

But looking more closely at the code, the first version was correct -- achievement_check() counts total nationalities across all cities. And indeed I've seen this in a game after I first conquered a city.

As far as I can tell this is intentional; I find no evidence that anyone other than me was ever confused about this. (This achievement was added in gna patch #4161 .)

I'll correct this (it's just strings), and also state more explicitly in README.achievements what the criterion is.

m-30-26-multicultural-description.patch (2.56 KB) m-30-26-multicultural-description.patch master, S3_0, S2_6 Jacob Nevins, 2020-01-14 09:53 AM

History

#1 Updated by Jacob Nevins about 1 year ago

  • Subject changed from "Multicultural" achivement described wrongly in rulesets to "Multicultural" achievement described wrongly in rulesets

#3 Updated by Jacob Nevins about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF