Project

Profile

Help

HostedRedmine.com has moved to the Planio platform. All logins and passwords remained the same. All users will be able to login and use Redmine just as before. Read more...
Send by e-mail

Bug #857675

Treat client option file load failure as first run

Added by Jacob Nevins 12 months ago. Updated 12 months ago.

Status:
Closed
Priority:
Low
Assignee:
Jacob Nevins
Category:
Client
Sprint/Milestone:
2.6.2
Start date:
Due date:
% Done:

0%

Estimated time:

Description

When options_load() positively decides that its option file has a certain path, but fails to load it, it mostly applies the same defaults as a completely fresh run; but it doesn't do client_option_adjust_defaults().

I noticed this when using the FREECIV_OPT environment variable pointing to a nonexistent file to simulate a fresh installation. But I think it would be the right behaviour for any case where we found an option file but couldn't even open it.

I think this bug has very little practical effect currently; only Gtk clients adjust options, and on modern systems they never actually make any adjustment (#765941-6).

m-30-26-option-load-fail-adjust.patch (810 Bytes) m-30-26-option-load-fail-adjust.patch master, S3_0, S2_6 Jacob Nevins, 2020-02-01 03:00 PM
m-30-26-option-load-fail-first-run.patch (1.17 KB) m-30-26-option-load-fail-first-run.patch master, S3_0, S2_6: supersedes previous patch Jacob Nevins, 2020-02-02 04:18 AM

Related issues

Blocks Freeciv - Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffectiveClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>
Blocks Freeciv - Bug #858203: client_option_adjust_defaults() runs too earlyClosed

<a title="Actions" class="icon-only icon-actions js-contextmenu" href="#">Actions</a>

History

#1 Updated by Jacob Nevins 12 months ago

  • Related to Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffective added

#2 Updated by Jacob Nevins 12 months ago

#3 Updated by Jacob Nevins 12 months ago

  • Subject changed from Option adjustments not applied if loading option file fails to Treat client option file load failure as first run
  • Status changed from Resolved to In Progress

Going to rework this as part of a bigger rework of the area. I don't plan to commit the existing patches.

#4 Updated by Jacob Nevins 12 months ago

  • Related to deleted (Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffective)

#5 Updated by Jacob Nevins 12 months ago

  • Blocks Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffective added

#6 Updated by Jacob Nevins 12 months ago

#7 Updated by Jacob Nevins 12 months ago

  • Blocks Bug #858203: client_option_adjust_defaults() runs too early added

#8 Updated by Jacob Nevins 12 months ago

  • Status changed from Resolved to Closed
Send by e-mail

Also available in: Atom PDF