Treat client option file load failure as first run
options_load() positively decides that its option file has a certain path, but fails to load it, it mostly applies the same defaults as a completely fresh run; but it doesn't do
I noticed this when using the
FREECIV_OPT environment variable pointing to a nonexistent file to simulate a fresh installation. But I think it would be the right behaviour for any case where we found an option file but couldn't even open it.
I think this bug has very little practical effect currently; only Gtk clients adjust options, and on modern systems they never actually make any adjustment (#765941-6).
#3 Updated by Jacob Nevins 5 months ago
- Subject changed from Option adjustments not applied if loading option file fails to Treat client option file load failure as first run
- Status changed from Resolved to In Progress
Going to rework this as part of a bigger rework of the area. I don't plan to commit the existing patches.