Project

General

Profile

Feature #858179

Change Gtk "Arrange widgets for small displays" default to disabled for new installations

Added by Jacob Nevins 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
gui-gtk-3
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Currently, the Gtk client defaults to "Arrange widgets for small displays" at first run, unless (on Gtk3+) it can positively determine that the screen is 'large' (height 1024 pixels or greater).

I propose to flip this so that the default "Arrange widgets for small displays" to disabled, unless the screen is positively determined to be 'small' (height smaller than 1024 pixels). (And, for Gtk2, just change the default.)

Existing users of a given client would see no change. Users migrating from Gtk2 to a newer Gtk client would probably see the new default once the issues in #765941 are addressed.

Since this is a defaults change, it could be controversial, so I'm seeking opinions.

The 'small_display_layout' option was added by Madeline Book in gna bug #13524 (2009, 2.2.0). It initially defaulted to false.

The default was changed to true (small by default) by pepeto in gna bug #16063 (2010, 2.2.3). This was triggered by a complaint from a 1024x600 user and followed a lot of work to improve the option's behaviour. Commit comment "Screen size issues reported many times by lot of users."

It became nominally dependent on the height of screen on first run for Gtk3 only (not Gtk2) in gna bug #23988 (2.6.0).

However, #765941 summarises a number of reasons why the screen-height-dependent behaviour doesn't take effect. So, many new users will still get the 'small' default, even on large screens.

I suspect that these days most users of desktop Freeciv clients will have screens that count as 'large' and will find that layout more comfortable; netbooks are much less of a thing these days. But I have no evidence for this -- it's just a guess -- so am happy to be corrected; it won't take much to talk me out of this.

I'd like to wrap this up for 2.6.2, so that new users going straight to Gtk3.22 get the right answer.

m-gtk3x-small-layout-not-default.patch (7.15 KB) m-gtk3x-small-layout-not-default.patch master (Gtk4 not tested) Jacob Nevins, 2020-02-02 04:21 AM
30-gtk3x-small-layout-not-default.patch (5.42 KB) 30-gtk3x-small-layout-not-default.patch S3_0 Jacob Nevins, 2020-02-02 04:21 AM
26-gtk3x-small-layout-not-default.patch (5.43 KB) 26-gtk3x-small-layout-not-default.patch S2_6 Jacob Nevins, 2020-02-02 04:21 AM

Related issues

Related to Freeciv - Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffectiveClosed

Related to Freeciv - Feature #860624: Don't default "Messages and Chat reports location" to "Merged"Closed

History

#1 Updated by Jacob Nevins 5 months ago

  • Related to Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffective added

#2 Updated by Chippo Elder 5 months ago

Jacob Nevins wrote:

I propose to flip this so that the default "Arrange widgets for small displays" to disabled, unless the screen is positively determined to be 'small' (height smaller than 1024 pixels). (And, for Gtk2, just change the default.)

I agree. I agree that it's a tricky situation, and I agree with your hand-wavy assessment of the distribution of screen sizes in the wild. Some users are going to be hurt either way, but I think your proposal above is the least hurtful on average.

#3 Updated by Jacob Nevins 5 months ago

  • Tracker changed from Bug to Feature

#4 Updated by Jacob Nevins 5 months ago

  • Category set to gui-gtk-3

#6 Updated by Jacob Nevins 5 months ago

  • Status changed from Resolved to Closed

#7 Updated by Jacob Nevins 5 months ago

  • Related to Feature #860624: Don't default "Messages and Chat reports location" to "Merged" added

Also available in: Atom PDF