Project

General

Profile

Bug #858208

Various bugs in GUI option migration

Added by Jacob Nevins 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Client
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Rework the way Gtk (and Qt) option migration works, to fix a few obscure bugs, and maybe make it easier to understand.

Full details with patch when I've ported it to all branches.

m-gui-migration-rework.patch (8.81 KB) m-gui-migration-rework.patch master (Gtk4 not tested) Jacob Nevins, 2020-02-02 04:37 AM
30-gui-migration-rework.patch (7.96 KB) 30-gui-migration-rework.patch S3_0 Jacob Nevins, 2020-02-02 04:37 AM
26-gui-migration-rework.patch (8.02 KB) 26-gui-migration-rework.patch S2_6 Jacob Nevins, 2020-02-02 04:37 AM

Related issues

Related to Freeciv - Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffectiveClosed

Blocked by Freeciv - Bug #858203: client_option_adjust_defaults() runs too earlyClosed

History

#1 Updated by Jacob Nevins 5 months ago

  • Related to Bug #765941: Gtk3.x automatic initial setting of "Arrange widgets for small displays" is ineffective added

#2 Updated by Jacob Nevins 5 months ago

Commit message describes what's done here:

  • Don't try to migrate anything on first run. (This was probably harmless, but unnecessary.)
  • On first boot of a client, mark all migrations relevant to it as done, so that they can't accidentally trigger on subsequent runs. (For instance, if the user explicitly enabled full-screen on first run, migrate_options_from_2_5() could clobber it back to FALSE on the second run.)
  • Avoid an enabled fullscreen setting from pre-2.6 Gtk2 leaking though to Gtk3.x/4; as with migration from 2.6+ Gtk2, we want to start again from defaults for this setting.
  • In the Gtk3.22/4 clients, migrate a pre-2.6 fullscreen preference that would have affected the pre-2.6 Gtk3 client (if there is no newer Gtk3-specific fullscreen preference).

As usual, gui-gtk-4.0 changes aren't even compile-tested, but unlike other patches these weren't a trivial port of gui-gtk-3.22, so higher risk that I've messed up.

#3 Updated by Jacob Nevins 5 months ago

  • Blocked by Bug #858203: client_option_adjust_defaults() runs too early added

#4 Updated by Jacob Nevins 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF