Project

General

Profile

Bug #858871

Main window can jump about when unit stack size changes

Added by Jacob Nevins 5 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
gui-gtk-3
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In the Gtk3.22 client, and the Gtk3 client on S3_0+, with "Arrange widgets for small displays not set", in tilesets where units are considered particularly wide (like ampliohexbig):

The left column of the main map view can be different widths depending on the number of units on the current unit's tile (different widths for 1/2, 3, and 4+). This causes the view to jump about irritatingly when changing focus.

Gtk2 is fine, as is Gtk3 on S2_6.

This is anti-correlated with use of gtk_pixcomm for unit_below_pixmap[]. I'm guessing that gtk_pixcomm was setting a fixed size request, and the new arrangement is not.

In gna bug #23562 , I solved a similar problem for the "more units" button in Gtk2/3 by adding an extra GtkContainer around more_arrow_pixmap_button's GdkPixbuf. That would presumably work here, although perhaps we can set a size request directly, I haven't looked yet.

(That 2015 bug says that it "reduces but doesn't completely eliminate the effect when using the Gtk3 client with the Freeciv theme. My prejudice is that this must be a bug in the theme, adding padding to layers of widget hierarchy that should be invisible. Doesn't happen with the system Greybird theme." I don't think I can have been running into this, as it looks like pixcomm removal was in 2016. So maybe there will be a remaining contribution from some padding.)

m-gtk3-unit-buttons-size.patch (3.83 KB) m-gtk3-unit-buttons-size.patch master (gtk4 not tested) Jacob Nevins, 2020-02-08 01:24 PM
30-gtk3-unit-buttons-size.patch (2.8 KB) 30-gtk3-unit-buttons-size.patch S3_0 Jacob Nevins, 2020-02-08 01:24 PM
26-gtk3-unit-buttons-size.patch (1.57 KB) 26-gtk3-unit-buttons-size.patch S2_6 Jacob Nevins, 2020-02-08 01:24 PM

History

#1 Updated by Jacob Nevins 5 months ago

Changes were easier than gna bug #23562, as the unit buttons are always shown even when they are not in use.

Gtk4 changes, as usual, not compile-tested, and they were not completely trivial due to feature #778842. I don't know for sure that Gtk4 suffered the symptom, or that this helps; but I think it probably did, and I think it should compile.
(Sorry about this. I should really sort out ability to compile against Gtk4.)

#2 Updated by Jacob Nevins 5 months ago

That 2015 bug says that it "reduces but doesn't completely eliminate the effect when using the Gtk3 client [...]"

I didn't see any remaining trouble with the Gtk3 client, so I guess something changed in the meantime.

#3 Updated by Jacob Nevins 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF